Add SOCKS proxy support to the API #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
force-pushed
the
ckozak/socks_proxy
branch
from
63318ba to
21a51d0
Compare
CRogers
reviewed
Nov 15, 2021
| .hostAndPort("localhost:1234") | ||
| .build()) | ||
| .isInstanceOf(IllegalArgumentException.class) | ||
| .hasMessage("credentials only valid for HTTP proxies"); |
There was a problem hiding this comment.
Hmm, can't socks proxies have credentials? Or is this a matter of just restricting the API for now?
There was a problem hiding this comment.
Seemingly they can but it seems a little scary with passwords sent in cleartext: https://www.rfc-editor.org/rfc/rfc1929
There was a problem hiding this comment.
This is very difficult to test, so I opted to limit the scope to the minimal feature set we need.
|
👍 |
|
Released 2.22.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Add SOCKS proxy support to the API
==COMMIT_MSG==
Possible downsides?
more proxies, socks is very hard to unit test