Skip to content

Made ServoX PEP 561 compliant #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Made ServoX PEP 561 compliant #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbbc1f2
Made ServoX PEP 561 compliant (see eg. https://github.com/python-poet…
ekalosak Oct 14, 2021
149f5e6
Merge branch 'main' into pytyped
ekalosak Nov 5, 2021
fcba26d
properly exporting type annotations for mypy
ekalosak Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added servo/py.typed
View file
Open in desktop
Empty file.
11 changes: 11 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# This setup.py is required to make type annotations available to dependent projects' mypy.
# Its metadata is nonauthoritative.
from distutils.core import setup

setup(
name="servox",
author="Blake Watters <[email protected]>",
version = "0.11.0",
package_data={"servo": ["py.typed"]},
packages=["servo"]
)
Comment on lines +1 to +11
Copy link
Contributor

@linkous8 linkous8 Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servox uses Poetry, please configure this accordingly in the pyroject.toml and remove the setup.py:

servox/pyproject.toml

Lines 10 to 12 in 81cba8d

packages = [
{ include = "servo" },
]

https://blog.whtsky.me/tech/2021/dont-forget-py.typed-for-your-typed-python-package/#adding-pytyped