Made ServoX PEP 561 compliant #349
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkous8
requested review from
linkous8
and removed request for
blakewatters
linkous8
suggested changes
Nov 17, 2021
Comment on lines
+1
to
+11
| # This setup.py is required to make type annotations available to dependent projects' mypy. | ||
| # Its metadata is nonauthoritative. | ||
| from distutils.core import setup | ||
|
|
||
| setup( | ||
| name="servox", | ||
| author="Blake Watters <[email protected]>", | ||
| version = "0.11.0", | ||
| package_data={"servo": ["py.typed"]}, | ||
| packages=["servo"] | ||
| ) |
There was a problem hiding this comment.
Servox uses Poetry, please configure this accordingly in the pyroject.toml and remove the setup.py:
Lines 10 to 12 in 81cba8d
https://blog.whtsky.me/tech/2021/dont-forget-py.typed-for-your-typed-python-package/#adding-pytyped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us export the typehints so dependent packages can mypy deeply.
Sources:
poetry builddoes not have included file in package_data python-poetry/poetry#1338 (comment)