Skip to content

Fixed StringIndexOutOfBoundsException caused by empty index expressions #19766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2025
Merged

Fixed StringIndexOutOfBoundsException caused by empty index expressions #19766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions server/src/main/java/org/opensearch/cluster/metadata/IndexNameExpressionResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,6 +1111,7 @@ private Set<String> innerResolve(Context context, List<String> expressions, Indi
String expression = expressions.get(i);
if (Strings.isEmpty(expression)) {
context.addResolutionError(indexNotFoundException(expression));
continue;
}
validateAliasOrIndex(context, expression);
if (aliasOrIndexExists(context, options, metadata, expression)) {
Expand Down
16 changes: 16 additions & 0 deletions server/src/test/java/org/opensearch/cluster/metadata/IndexNameExpressionResolverTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2112,6 +2112,22 @@ public void testInvalidIndex() {
assertEquals("Invalid index name [_foo], must not start with '_'.", iine.getMessage());
}

public void testInvalidEmptyIndex() {
Metadata.Builder mdBuilder = Metadata.builder().put(indexBuilder("test"));
ClusterState state = ClusterState.builder(new ClusterName("_name")).metadata(mdBuilder).build();
IndexNameExpressionResolver.Context context = new IndexNameExpressionResolver.Context(
state,
IndicesOptions.lenientExpandOpen(),
false
);

IndexNotFoundException indexNotFoundException = expectThrows(
IndexNotFoundException.class,
() -> indexNameExpressionResolver.concreteIndexNames(context, "")
);
assertEquals("no such index []", indexNotFoundException.getMessage());
}

public void testIgnoreThrottled() {
Metadata.Builder mdBuilder = Metadata.builder()
.put(
Expand Down
Loading