-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fixed StringIndexOutOfBoundsException caused by empty index expressions #19766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n strings Signed-off-by: Nils Bandener <[email protected]>
|
Regarding a changelog entry: This fixes an issue caused by a change that has not been released yet. Is for this a change log entry still wanted/necessary? |
|
❌ Gradle check result for c5d4c57: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
I added the skip-changelog label. |
|
❌ Gradle check result for c5d4c57: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for c5d4c57: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19766 +/- ##
============================================
- Coverage 73.12% 73.12% -0.01%
+ Complexity 70973 70963 -10
============================================
Files 5737 5737
Lines 324767 324768 +1
Branches 46982 46982
============================================
- Hits 237483 237478 -5
- Misses 68151 68163 +12
+ Partials 19133 19127 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…n strings (opensearch-project#19766) Signed-off-by: Nils Bandener <[email protected]>
Description
This fixes a regression introduced by #18523 ; calling
IndexNameExpressionResolver.concreteIndices()with an index expression containing an empty string should throw anIndexNotFoundException. However, this regressed to throwing aStringIndexOutOfBoundsException. This change fixes the issue.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.