Skip to content

Conversation

@nibix
Copy link
Contributor

@nibix nibix commented Oct 25, 2025

Description

This fixes a regression introduced by #18523 ; calling IndexNameExpressionResolver.concreteIndices() with an index expression containing an empty string should throw an IndexNotFoundException. However, this regressed to throwing a StringIndexOutOfBoundsException. This change fixes the issue.

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@nibix nibix requested a review from a team as a code owner October 25, 2025 07:36
@nibix
Copy link
Contributor Author

nibix commented Oct 25, 2025

Regarding a changelog entry:

This fixes an issue caused by a change that has not been released yet. Is for this a change log entry still wanted/necessary?

@github-actions
Copy link
Contributor

❌ Gradle check result for c5d4c57: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@cwperks
Copy link
Member

cwperks commented Oct 25, 2025

Regarding a changelog entry:

This fixes an issue caused by a change that has not been released yet. Is for this a change log entry still wanted/necessary?

I added the skip-changelog label.

@github-actions
Copy link
Contributor

❌ Gradle check result for c5d4c57: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for c5d4c57: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for c5d4c57: SUCCESS

@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.12%. Comparing base (cb9c30b) to head (c5d4c57).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19766      +/-   ##
============================================
- Coverage     73.12%   73.12%   -0.01%     
+ Complexity    70973    70963      -10     
============================================
  Files          5737     5737              
  Lines        324767   324768       +1     
  Branches      46982    46982              
============================================
- Hits         237483   237478       -5     
- Misses        68151    68163      +12     
+ Partials      19133    19127       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cwperks cwperks merged commit 147d6df into opensearch-project:main Oct 25, 2025
40 of 47 checks passed
anandpatel9998 pushed a commit to anandpatel9998/OpenSearch that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants