Skip to content

[Backport 2.x] Fix ConcurrentModificationException in RemoteFsTimestampAwareTranslog.trimUnreferencedReaders #17460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

[Backport 2.x] Fix ConcurrentModificationException in RemoteFsTimestampAwareTranslog.trimUnreferencedReaders #17460

merged 1 commit into from
Mar 24, 2025

Conversation

@opensearch-trigger-bot
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Feb 26, 2025

Backport 171433c from #17028.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025

❌ Gradle check result for 95bdae4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025

❌ Gradle check result for 95bdae4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025

❌ Gradle check result for 95bdae4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Feb 26, 2025
Open
Closed
@kaushalmahi12 kaushalmahi12 mentioned this pull request Feb 26, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025

❌ Gradle check result for 95bdae4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions @sachinpkale
Fix ConcurrentModificationException in RemoteFsTimestampAwareTranslog…
7ff4c9a 
….trimUnreferencedReaders (#17028)

* Fix ConcurrentModificationException in RemoteFsTimestampAwareTranslog.trimUnreferencedReaders

Signed-off-by: Sachin Kale <[email protected]>

* Address PR comments

Signed-off-by: Sachin Kale <[email protected]>

---------

Signed-off-by: Sachin Kale <[email protected]>
(cherry picked from commit 171433c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@sachinpkale sachinpkale force-pushed the backport/backport-17028-to-2.x branch from 95bdae4 to 7ff4c9a Compare March 24, 2025 06:07
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025

✅ Gradle check result for 7ff4c9a: SUCCESS

@codecov
Copy link

codecov bot commented Mar 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.06%. Comparing base (87b4b91) to head (7ff4c9a).
Report is 3 commits behind head on 2.x.

Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #17460      +/-   ##
============================================
+ Coverage     72.02%   72.06%   +0.04%     
- Complexity    66032    66113      +81     
============================================
  Files          5342     5347       +5     
  Lines        307289   307496     +207     
  Branches      44848    44891      +43     
============================================
+ Hits         221316   221603     +287     
+ Misses        67505    67464      -41     
+ Partials      18468    18429      -39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sachinpkale sachinpkale merged commit b34b8cb into 2.x Mar 24, 2025
45 checks passed
@github-actions github-actions bot deleted the backport/backport-17028-to-2.x branch March 24, 2025 08:24
This was referenced Mar 24, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sachinpkale sachinpkale sachinpkale approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sachinpkale @linuxpi