Skip to content

[Backport 2.x] [rule based autotagging] add attribute value store #17441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2025
Merged

[Backport 2.x] [rule based autotagging] add attribute value store #17441

merged 2 commits into from
Feb 27, 2025

Conversation

@opensearch-trigger-bot
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Feb 24, 2025

Backport 4648c3f from #17342.

@github-actions
[Rule based autotagging] Add attribute value store (#17342)
3312432 
* [rule based autotagging] add attribute value store

Signed-off-by: Kaushal Kumar <[email protected]>

* add CHANGELOG entry

Signed-off-by: Kaushal Kumar <[email protected]>

* make the store interface generic

Signed-off-by: Kaushal Kumar <[email protected]>

* run spotless apply

Signed-off-by: Kaushal Kumar <[email protected]>

* add missing javadoc

Signed-off-by: Kaushal Kumar <[email protected]>

* improve javadoc for attribute value store

Signed-off-by: Kaushal Kumar <[email protected]>

* improve binary search bisecting expression

Signed-off-by: Kaushal Kumar <[email protected]>

* add licenses directory

Signed-off-by: Kaushal Kumar <[email protected]>

---------

Signed-off-by: Kaushal Kumar <[email protected]>
(cherry picked from commit 4648c3f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2025

❌ Gradle check result for 3312432: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

❌ Gradle check result for 3312432: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Feb 25, 2025
Open
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

❌ Gradle check result for 3312432: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Contributor

jainankitk commented Feb 25, 2025

❌ Gradle check result for 3312432: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Cardinality tests seems to be failing consistently:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/53887/testReport/) (14 failures / +11)

    [org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/80_typed_keys/Test typed keys parameter for cardinality aggregation}](https://build.ci.opensearch.org/job/gradle-check/53887/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_aggregation_80_typed_keys_Test_typed_keys_parameter_for_cardinality_aggregation_/)
    [org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric/Missing field without missing param}](https://build.ci.opensearch.org/job/gradle-check/53887/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_aggregation_170_cardinality_metric_Missing_field_without_missing_param_/)
    [org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric/Only aggs test}](https://build.ci.opensearch.org/job/gradle-check/53887/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_aggregation_170_cardinality_metric_Only_aggs_test_/)
    [org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric/Missing field with missing param}](https://build.ci.opensearch.org/job/gradle-check/53887/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_aggregation_170_cardinality_metric_Missing_field_with_missing_param_/)
    [org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric_unsigned/Missing field without missing param}](https://build.ci.opensearch.org/job/gradle-check/53887/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_aggregation_170_cardinality_metric_unsigned_Missing_field_without_missing_param_/)
    [org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric_unsigned/Only aggs test}](https://build.ci.opensearch.org/job/gradle-check/53887/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_aggregation_170_cardinality_metric_unsigned_Only_aggs_test_/)
    [org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric_unsigned/Metadata test}](https://build.ci.opensearch.org/job/gradle-check/53887/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_aggregation_170_cardinality_metric_unsigned_Metadata_test_/)
    [org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric/Basic test}](https://build.ci.opensearch.org/job/gradle-check/53887/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_aggregation_170_cardinality_metric_Basic_test_/)
    [org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric_unsigned/Basic test}](https://build.ci.opensearch.org/job/gradle-check/53887/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_aggregation_170_cardinality_metric_unsigned_Basic_test_/)
    [org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric_unsigned/profiler unsigned_long}](https://build.ci.opensearch.org/job/gradle-check/53887/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_aggregation_170_cardinality_metric_unsigned_profiler_unsigned_long_/)
    [org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/40_range/Date range unmapped with children}](https://build.ci.opensearch.org/job/gradle-check/53887/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_aggregation_40_range_Date_range_unmapped_with_children_/)
    [org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric/profiler double}](https://build.ci.opensearch.org/job/gradle-check/53887/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_aggregation_170_cardinality_metric_profiler_double_/)
    [org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/170_cardinality_metric_unsigned/profiler string}](https://build.ci.opensearch.org/job/gradle-check/53887/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_search_aggregation_170_cardinality_metric_unsigned_profiler_string_/)
    [org.opensearch.remotemigration.RemotePrimaryRelocationIT.testMixedModeRelocation_FailInFinalize](https://build.ci.opensearch.org/job/gradle-check/53887/testReport/junit/org.opensearch.remotemigration/RemotePrimaryRelocationIT/testMixedModeRelocation_FailInFinalize/)

@kaushalmahi12
Copy link
Contributor

kaushalmahi12 commented Feb 26, 2025

I see that the following PRs are also failing due to same test suite

There might be some other underlying reason for failures.

@cwperks
Copy link
Member

cwperks commented Feb 27, 2025

@kaushalmahi12 Could it be because #17380 is not in 2.19?

I am seeing this error:

» WARN ][o.o.a.s.TransportSearchAction] [v2.19.1-2] onPhaseStart listener [org.opensearch.action.search.SearchRequestStats@a4382da] failed
» java.lang.IllegalArgumentException: No enum constant org.opensearch.action.search.SearchPhaseName.CREATE_PIT
» at java.****/java.lang.Enum.valueOf(Enum.java:293) ~[?:?]
» at org.opensearch.action.search.SearchPhaseName.valueOf(SearchPhaseName.java:18) ~[opensearch-2.19.1-SNAPSHOT.jar:2.19.1-SNAPSHOT]
» at org.opensearch.action.search.SearchPhase.getSearchPhaseName(SearchPhase.java:77) ~[opensearch-2.19.1-SNAPSHOT.jar:2.19.1-SNAPSHOT]
» at org.opensearch.action.search.SearchRequestStats.onPhaseStart(SearchRequestStats.java:76) ~[opensearch-2.19.1-SNAPSHOT.jar:2.19.1-SNAPSHOT]
» at org.opensearch.action.search.SearchRequestOperationsListener$CompositeListener.onPhaseStart(SearchRequestOperationsListener.java:87) [opensearch-2.19.1-SNAPSHOT.jar:2.19.1-SNAPSHOT]

@cwperks
Copy link
Member

cwperks commented Feb 27, 2025

BWC failures were because #17419 was merged into 2.19 before it was merged into 2.x.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025

❕ Gradle check result for c684bfe: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.95%. Comparing base (7fc607b) to head (c684bfe).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...n/wlm/rule/storage/DefaultAttributeValueStore.java 92.59% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #17441      +/-   ##
============================================
+ Coverage     71.92%   71.95%   +0.02%     
- Complexity    65942    65968      +26     
============================================
  Files          5341     5342       +1     
  Lines        307223   307250      +27     
  Branches      44838    44842       +4     
============================================
+ Hits         220981   221083     +102     
+ Misses        67788    67710      -78     
- Partials      18454    18457       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwperks cwperks merged commit ec52148 into 2.x Feb 27, 2025
45 checks passed
@github-actions github-actions bot deleted the backport/backport-17342-to-2.x branch February 27, 2025 23:32
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Feb 28, 2025
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jul 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jainankitk jainankitk jainankitk approved these changes

@cwperks cwperks cwperks approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jainankitk @kaushalmahi12 @cwperks