Skip to content

Conversation

@ayesha-waris
Copy link
Contributor

INF-502

Description

When clicking the filter buttons the paragon hover state color shows up, the required change should be a green check icon next to the text.

Before

Filters

After

CPT2303281531-460x287

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (58b6b69) 90.78% compared to head (add6e44) 90.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   90.78%   90.79%           
=======================================
  Files         161      161           
  Lines        3234     3236    +2     
  Branches      883      885    +2     
=======================================
+ Hits         2936     2938    +2     
  Misses        276      276           
  Partials       22       22           
Impacted Files Coverage Δ
.../discussions/learners/learner/LearnerFilterBar.jsx 100.00% <100.00%> (ø)
...iscussions/posts/post-filter-bar/PostFilterBar.jsx 98.33% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ayesha-waris ayesha-waris merged commit 24163d1 into master Mar 28, 2023
moonesque pushed a commit to edSPIRIT/frontend-app-discussions that referenced this pull request Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants