Skip to content

Commit add6e44

Browse files
committed
fix: hover color removed when filter buttons are clicked
1 parent 58b6b69 commit add6e44

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

src/discussions/learners/learner/LearnerFilterBar.jsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ const ActionItem = ({
2727
data-testid={value === selected ? `${value} selected` : null}
2828
style={{ cursor: 'pointer' }}
2929
aria-checked={value === selected}
30+
// eslint-disable-next-line jsx-a11y/no-noninteractive-tabindex
31+
tabIndex={value === selected ? '0' : '-1'}
3032
>
3133
<Icon src={Check} className={classNames('text-success mr-2', { invisible: value !== selected })} />
3234
<Form.Radio id={id} className="sr-only sr-only-focusable" value={value} tabIndex="0">

src/discussions/posts/post-filter-bar/PostFilterBar.jsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ export const ActionItem = ({
4141
data-testid={value === selected ? 'selected' : null}
4242
style={{ cursor: 'pointer' }}
4343
aria-checked={value === selected}
44+
// eslint-disable-next-line jsx-a11y/no-noninteractive-tabindex
45+
tabIndex={value === selected ? '0' : '-1'}
4446
>
4547
<Icon src={Check} className={classNames('text-success mr-2', { invisible: value !== selected })} />
4648
<Form.Radio id={id} className="sr-only sr-only-focusable" value={value} tabIndex="0">

src/index.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ header {
251251
min-width: 29rem;
252252
}
253253

254-
.filter-menu:focus-within {
254+
.filter-menu:focus-visible {
255255
background-color: #e9e6e4 !important;
256256
}
257257

0 commit comments

Comments
 (0)