Skip to content

Conversation

@trentm
Copy link
Contributor

@trentm trentm commented Feb 11, 2025

Fixes these 'lint:deps' hits:

Unused dependencies (2)
@opentelemetry/otlp-transformer  packages/opentelemetry-test-utils/package.json
@opentelemetry/core              plugins/web/opentelemetry-plugin-react-load/package.json
Unlisted dependencies (1)
@opentelemetry/instrumentation  plugins/web/opentelemetry-plugin-react-load/src/BaseOpenTelemetryComponent.ts

lint:deps was accidentally removed in a merge-from-main in #2493.

Unused dependencies (2)
@opentelemetry/otlp-transformer  packages/opentelemetry-test-utils/package.json
@opentelemetry/core              plugins/web/opentelemetry-plugin-react-load/package.json
Unlisted dependencies (1)
@opentelemetry/instrumentation  plugins/web/opentelemetry-plugin-react-load/src/BaseOpenTelemetryComponent.ts
@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.40%. Comparing base (143a1f4) to head (10cc3dd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2709   +/-   ##
=======================================
  Coverage   92.40%   92.40%           
=======================================
  Files         171      171           
  Lines        8140     8140           
  Branches     1652     1652           
=======================================
  Hits         7522     7522           
  Misses        618      618           

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍
Sorry - I should've checked that. In my mind @opentelemetry/instrumentation was a "safe" replacement as all of the instrumentation packages usually depend on it, but I was not considering that the react-load one is not an instrumentation package in that sense.

@pichlermarc pichlermarc merged commit eb43a69 into open-telemetry:main Feb 12, 2025
25 checks passed
@trentm trentm deleted the tm-restore-lint-deps branch February 12, 2025 19:32
deejay1 pushed a commit to deejay1/opentelemetry-js-contrib that referenced this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment