-
Notifications
You must be signed in to change notification settings - Fork 354
Add host.arch attribute to HostDetector and update tests #3147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Kielek
merged 20 commits into
open-telemetry:main
from
AguirreMoy:u/aguirremoy/host-arch
Oct 2, 2025
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7ae7583
arch
AguirreMoy 0dd4400
update
AguirreMoy 188cfd9
lint
AguirreMoy 4431f02
undo format
AguirreMoy 4e65217
undo format
AguirreMoy d88c86d
changelog update
AguirreMoy cb65f4c
update attributes buffer
AguirreMoy 7c05a1a
Specify host.arch only on .net
AguirreMoy 2175618
simplify naming
AguirreMoy ea1f32f
map to existing otel semantics
AguirreMoy bc8cc66
map to semantics
AguirreMoy ed77e8d
Merge branch 'main' into u/aguirremoy/host-arch
AguirreMoy 3dfcab2
Merge branch 'main' into u/aguirremoy/host-arch
AguirreMoy ec7a3f8
Merge branch 'main' into u/aguirremoy/host-arch
Kielek 87fefce
direct feedback - changelog and readme
Kielek 13f45b7
PR feedback - add only well known architectures
Kielek 0142e7b
remove redundant comment
Kielek fdb04ed
PR feedback -fix compilation on netstandard
Kielek 327186e
compilation warning for .NET Fx 4.7.1+
Kielek 97cb392
Switching to OSArchitecture
Kielek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not make all the code #if NET instead of #if !NETFRAMEWORK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NetStandard targets can compile with this 4 cases