- 
                Notifications
    You must be signed in to change notification settings 
- Fork 356
Add host.arch attribute to HostDetector and update tests #3147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add host.arch attribute to HostDetector and update tests #3147
Conversation
| /easycla | 
| Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #3147      +/-   ##
==========================================
+ Coverage   69.90%   70.03%   +0.12%     
==========================================
  Files         439      429      -10     
  Lines       16919    16888      -31     
==========================================
  Hits        11827    11827              
+ Misses       5092     5061      -31     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
 🚀 New features to boost your workflow:
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Please fix some issues I have found.
| Hi @Kielek , thanks for the quick review. I've addressed your comments. I marked the easy ones as resolved and left the remainder open for further feedback. Thanks! | 
Partially implements #1516
Changes
Adds detection and reporting of the host architecture (host.arch) using
System.Runtime.InteropServices.RuntimeInformation.ProcessArchitecturein theHostDetector.The host.arch attribute is now included in the detected resource attributes on supported platforms. The README has been updated to document the new attribute, and unit tests have been enhanced to verify that host.arch is present and correctly set.
This improves observability by providing architecture information as part of the host resource metadata.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes