Skip to content

Conversation

@AguirreMoy
Copy link
Contributor

Partially implements #1516

Changes

Adds detection and reporting of the host architecture (host.arch) using System.Runtime.InteropServices.RuntimeInformation.ProcessArchitecture in the HostDetector.

The host.arch attribute is now included in the detected resource attributes on supported platforms. The README has been updated to document the new attribute, and unit tests have been enhanced to verify that host.arch is present and correctly set.

This improves observability by providing architecture information as part of the host resource metadata.

CleanShot 2025-09-24 at 20 04 16@2x

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@AguirreMoy AguirreMoy requested a review from a team as a code owner September 25, 2025 03:06
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 25, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot requested review from Kielek and lachmatt September 25, 2025 03:06
@github-actions github-actions bot added the comp:resources.host Things related to OpenTelemetry.Resources.Host label Sep 25, 2025
@AguirreMoy AguirreMoy changed the base branch from main to main-1.3.0 September 25, 2025 03:43
@AguirreMoy AguirreMoy changed the base branch from main-1.3.0 to main September 25, 2025 03:43
@AguirreMoy
Copy link
Contributor Author

/easycla

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.03%. Comparing base (1b1f8b3) to head (97cb392).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/OpenTelemetry.Resources.Host/HostDetector.cs 61.90% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3147      +/-   ##
==========================================
+ Coverage   69.90%   70.03%   +0.12%     
==========================================
  Files         439      429      -10     
  Lines       16919    16888      -31     
==========================================
  Hits        11827    11827              
+ Misses       5092     5061      -31     
Flag Coverage Δ
unittests-Instrumentation.Cassandra ?
unittests-Resources.Host 71.85% <61.90%> (-2.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/OpenTelemetry.Resources.Host/HostDetector.cs 75.20% <61.90%> (-2.90%) ⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Please fix some issues I have found.

@AguirreMoy
Copy link
Contributor Author

Hi @Kielek , thanks for the quick review. I've addressed your comments. I marked the easy ones as resolved and left the remainder open for further feedback. Thanks!

@AguirreMoy AguirreMoy requested a review from Kielek September 30, 2025 18:38
This was referenced Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:resources.host Things related to OpenTelemetry.Resources.Host

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants