-
-
Notifications
You must be signed in to change notification settings - Fork 715
Add manual smoke test plans for MS Office, Libre Office, Web Browsers, IDEs #18419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds manual smoke test plans to ensure NVDA functionality across MS Office, LibreOffice, and major web browsers when migrating to 64-bit.
- Introduce a comprehensive smoke test plan for web browsers (Chrome, Edge, Firefox).
- Add smoke test plans for Microsoft Office applications (Outlook, Word, PowerPoint, Excel).
- Add smoke test plans for LibreOffice applications (Writer, Calc, Impress).
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
tests/manual/applications/webBrowsers.md | Add smoke test plan for major web browsers |
tests/manual/applications/msOffice.md | Add smoke test plan covering MS Office applications |
tests/manual/applications/libreOffice.md | Add smoke test plan for LibreOffice applications |
Comments suppressed due to low confidence (2)
tests/manual/applications/webBrowsers.md:62
- The link path for the Forms example appears to reference the landmarks directory; update it to the correct patterns/form/examples path to match other ARIA sample links.
* [Forms](../../../include/w3c-aria-practices/content/patterns/landmarks/examples/form.html)
tests/manual/applications/libreOffice.md:1
- [nitpick] Consider adding a UIA Settings section (similar to the MS Office plan) to specify required UIA toggles for LibreOffice, ensuring consistency across all manual test plans.
# NVDA LibreOffice Smoke Testing Plan
See test results for failed build of commit 43168a5564 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review
|
||
### Steps | ||
|
||
1. Use `ctrl+f` to search within the current file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You already had us do that in Editor Accessibility step 3
|
||
1. Use `ctrl+f` to search within the current file | ||
1. Use `ctrl+shift+f` to search across the project | ||
1. Use `ctrl+shift+n` to find any file, class, or symbol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You said ctrl+shift+n
creates a new project in Project Operations step 1.
1. Use `ctrl+shift+f` to search across the project | ||
1. Use `ctrl+shift+n` to find any file, class, or symbol | ||
1. Use `ctrl+n` to find a class | ||
1. Use `ctrl+shift+n` to find a file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You already had us use ctrl+shift+n
to "find any file, class, or symbol"
|
||
1. Use `ctrl+alt+s` to open Settings/Preferences | ||
1. Navigate through settings categories using arrow keys | ||
1. Use `ctrl+alt+s` to open Plugins settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You already had us use ctrl+alt+s
to open settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a JetBrains user, so some of these comments may be obvious to experienced JetBrains users
1. Type and navigate code in the editor using arrow keys | ||
1. Use `ctrl+home` and `ctrl+end` to jump to start/end of file | ||
1. Use `ctrl+f` to open the find dialog and search for text | ||
1. Use `ctrl+h` to open the replace dialog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has actually using text replacement intentionally been omitted?
|
||
### Steps | ||
|
||
1. Use `ctrl+f` to search within the current file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already done in Code Editor Accessibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a Visual Studio user, so some of these questions/comments may be obvious to experienced users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet reviewed
1. Verify NVDA announces the VSCodium window title | ||
1. Use `ctrl+shift+p` to open the command palette | ||
1. Use `ctrl+tab` to switch between open files/tabs | ||
1. Use `ctrl+b` to toggle the sidebar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about in Codium, but in VS Code Ctrl+B
doesn't announce anything, unless you're focused in the sidebar, in which case you'll hear something because the focus moves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of VS Code 1.103.0 showing and hiding the primary and secondary sidebars is now announced.
1. Use `ctrl+b` to toggle the sidebar | ||
1. Use `f1` to open the command palette (alternative) | ||
1. Use `ctrl+shift+e` to focus the Explorer | ||
1. Use `ctrl+shift+f` to focus the Search panel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Use `ctrl+shift+f` to focus the Search panel | |
1. Use `ctrl+shift+f` to focus the Search panel | |
1. Use `f6` to navigate between sections of the window. |
|
||
### Expected Results | ||
|
||
* NVDA announces line numbers, text, and search results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we support reporting line numbers in Monaco
|
||
1. Use ``ctrl+` `` to open the integrated terminal | ||
1. Type commands and review output | ||
1. Use `ctrl+shift+\` to create a new terminal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Use `ctrl+shift+\` to create a new terminal | |
1. Use ``ctrl+shift+` `` to create a new terminal |
1. Use ``ctrl+` `` to open the integrated terminal | ||
1. Type commands and review output | ||
1. Use `ctrl+shift+\` to create a new terminal | ||
1. Use `ctrl+tab` to switch between terminal and editor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I would not switch this way. I'd use ctrl+1
to switch back to editor group 1.
### Steps | ||
|
||
1. Use ``ctrl+` `` to open the integrated terminal | ||
1. Type commands and review output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly worth noting that you can use alt+f2
or ctrl+upArrow
to enter accessible view to review terminal output, and esc
or ctrl+downArrow
(on the last line of output) to close it
|
||
1. Launch Writer | ||
1. Verify NVDA announces the Writer window title | ||
1. Use `ctrl+n` to create a new document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's just my settings, but you're already in a blank document when you open Writer
1. Launch Writer | ||
1. Verify NVDA announces the Writer window title | ||
1. Use `ctrl+n` to create a new document | ||
1. Use `tab` to move through the toolbar and document area |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will just insert tabs into the document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Use `tab` to move through the toolbar and document area | |
1. Use `f6` and `tab` to move through the toolbar and document area |
|
||
#### Steps | ||
|
||
1. Type sample text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth mentioning that you can get some sample text to work with by typing "DT" or "LOREM" followed by f3
?
1. Use `f7` for spell check | ||
1. Use `ctrl+f` to open the find bar | ||
1. Use `ctrl+g` to go to a page/section | ||
1. Use `shift+f5` to return to last edit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to save, close and reopen a document for this to work. Also doesn't seem like NVDA is aware that the caret moves in this case.
|
||
#### Steps | ||
|
||
1. Use `f7` for spell check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be aware of #17887
|
||
1. Launch Impress | ||
1. Verify NVDA announces the Impress window title | ||
1. Use `ctrl+n` to create a new presentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I first open LO Impress, I get a new slideshow wizard. Pressing Ctrl+N
in this window has no effect.
1. Verify NVDA announces the Impress window title | ||
1. Use `ctrl+n` to create a new presentation | ||
1. Use `tab` to move through the toolbar and slide area | ||
1. Use arrow keys to move between slides and within slide content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Page up and down moves between slides. Arrow keys moves the selected object on the slide
#### Expected Results | ||
|
||
* NVDA announces window title, toolbar, and slide area | ||
* Navigation is smooth and consistent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arguably not the case at present
|
||
#### Steps | ||
|
||
1. Type sample text on a slide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you can type directly onto a slide; you have to type into a textbox
1. Use `ctrl+m` to add a new slide | ||
1. Use `ctrl+s` to save, `ctrl+o` to open a presentation | ||
1. Use `f5` to start slideshow, `esc` to exit | ||
1. Use arrow keys to move between slides during slideshow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing is currently reported when presenting in LOI
Part of #16304
Creates smoke test plans for MS office, Libre Office, IDEs and Web browsers to help test against regressions when migrating to 64bit