Skip to content

fix(SelectMenu/InputMenu): ensure object compare with by prop #4791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2025
Merged

fix(SelectMenu/InputMenu): ensure object compare with by prop #4791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0703390
fix(SelectMenu): issue props by with non native
rdjanuar Aug 19, 2025
a6951bb
up
rdjanuar Aug 28, 2025
b10a338
Merge branch 'v2' into fix/select-menu
rdjanuar Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/runtime/components/forms/InputMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,10 @@ export default defineComponent({
}
})

function isObject(object: any): object is boolean {
return !Array.isArray(object) && object !== null && typeof object === 'object'
}

const label = computed(() => {
if (!props.modelValue) return null

Expand All @@ -334,7 +338,7 @@ export default defineComponent({
}

function compareValues(value1: any, value2: any) {
if (by.value && typeof by.value !== 'function' && typeof value1 === 'object' && typeof value2 === 'object') {
if (by.value && typeof by.value !== 'function' && isObject(value1) && isObject(value2)) {
return isEqual(value1[props.by], value2[props.by])
}
return isEqual(value1, value2)
Expand Down
6 changes: 5 additions & 1 deletion src/runtime/components/forms/SelectMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ export default defineComponent({

const selected = computed(() => {
function compareValues(value1: any, value2: any) {
if (by.value && typeof by.value !== 'function' && typeof value1 === 'object' && typeof value2 === 'object') {
if (by.value && typeof by.value !== 'function' && isObject(value1) && isObject(value2)) {
return isEqual(value1[by.value], value2[by.value])
}
return isEqual(value1, value2)
Expand Down Expand Up @@ -527,6 +527,10 @@ export default defineComponent({
return get(obj, key)
}

function isObject(object: any): object is boolean {
return !Array.isArray(object) && object !== null && typeof object === 'object'
}

const filteredOptions = computed(() => {
if (!query.value || debouncedSearch) {
return options.value
Expand Down
Loading