Skip to content

Conversation

@rdjanuar
Copy link
Contributor

@rdjanuar rdjanuar commented Aug 19, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

there's an issue when we provide by props with null modelValue causing error on compareValues function.

Screenshot 2025-08-19 at 15 12 21

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 19, 2025

npm i https://pkg.pr.new/@nuxt/ui@4791

commit: b10a338

@rdjanuar rdjanuar changed the title fix(SelectMenu): issue props by with non native fix(SelectMenu): issue selected value Aug 19, 2025
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this change should be applied to InputMenu as well? πŸ€”

@rdjanuar rdjanuar requested a review from benjamincanac August 28, 2025 11:03
@rdjanuar rdjanuar changed the title fix(SelectMenu): issue selected value fix(SelectMenu/InputMenu): issue selected value Aug 28, 2025
@benjamincanac benjamincanac changed the title fix(SelectMenu/InputMenu): issue selected value fix(SelectMenu/InputMenu): ensure object compare with by prop Sep 1, 2025
@benjamincanac benjamincanac merged commit 44382cd into nuxt:v2 Sep 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants