Skip to content

Fix thread-safety issue in AutoValueProvidersFactory #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Fix thread-safety issue in AutoValueProvidersFactory #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
### unreleased

* [UPDATE] Build update to run on non-Windows platforms. Thanks @joaopgrassi! (#592, #335)
* [FIX] Fix NSubstitute could fail in concurrent environment due to auto-value providers initialization. (#600, @zvirja)

### 4.2.1 (July 2019)

Expand Down
2 changes: 1 addition & 1 deletion src/NSubstitute/Routing/AutoValues/AutoValueProvidersFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public IReadOnlyCollection<IAutoValueProvider> CreateProviders(ISubstituteFactor
IAutoValueProvider[] result = null;
var lazyResult = new Lazy<IReadOnlyCollection<IAutoValueProvider>>(
() => result ?? throw new InvalidOperationException("Value was not constructed yet."),
LazyThreadSafetyMode.None);
LazyThreadSafetyMode.PublicationOnly);

result = new IAutoValueProvider[]
{
Expand Down