Fix thread-safety issue in AutoValueProvidersFactory #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtchepak
approved these changes
Dec 17, 2019
|
@dtchepak Does it worth making a patch release? It’s unlikely we could want to fix something else ;) |
|
Any update on getting a patch release for this? |
|
@brianfeucht Sorry for the delay, I was hoping to batch up some other changes but haven't been able to get those done. I've just released 4.2.2 that includes this change, please let me know how it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #600
Use thread-safe option of Lazy.
Also registered a tech dept in #551 to improve this place in future major update. We cannot, unfortunately, do it now, as that requires breaking changes.