vm: fix MODPOW operation #3649
Merged
vm: fix MODPOW operation #3649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
AnnaShaleva
added a commit
to neo-project/neo
that referenced
this pull request
Oct 28, 2024
We need to ensure that NeoGo VM behaviour is compatible, ref. nspcc-dev/neo-go#3649. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
reviewed
Oct 28, 2024
AnnaShaleva
added a commit
to neo-project/neo
that referenced
this pull request
Oct 28, 2024
We need to ensure that NeoGo VM behaviour is compatible, ref. nspcc-dev/neo-go#3649. Signed-off-by: Anna Shaleva <[email protected]>
9 tasks
|
Also please, add one more compatibility test from neo-project/neo#3557: |
AliceInHunterland
force-pushed
the
vm-modpow
branch
from
787ee3a to
7a49e5f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3649 +/- ##
==========================================
- Coverage 83.26% 83.19% -0.07%
==========================================
Files 334 334
Lines 46488 46494 +6
==========================================
- Hits 38707 38681 -26
- Misses 6205 6240 +35
+ Partials 1576 1573 -3 ☔ View full report in Codecov by Sentry. |
shargon
added a commit
to neo-project/neo
that referenced
this pull request
Oct 29, 2024
We need to ensure that NeoGo VM behaviour is compatible, ref. nspcc-dev/neo-go#3649. Signed-off-by: Anna Shaleva <[email protected]> Co-authored-by: Shargon <[email protected]>
AnnaShaleva
reviewed
Oct 30, 2024
AliceInHunterland
force-pushed
the
vm-modpow
branch
from
7a49e5f to
b24144a
Compare
Close #3612 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
vm-modpow
branch
from
b24144a to
cccbe84
Compare
AnnaShaleva
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3612