Skip to content

OpCodes: extend MODPOW tests with negative base/exp/mod #3557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2024
Merged

OpCodes: extend MODPOW tests with negative base/exp/mod #3557

merged 2 commits into from
Oct 29, 2024

Conversation

@AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva commented Oct 28, 2024

Description

We need to ensure that NeoGo VM behaviour is compatible, ref. nspcc-dev/neo-go#3649. Similar to #3513.

Type of change

  • Unit test.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@AnnaShaleva
OpCodes: extend MODPOW tests with negative base/exp/mod
96565fc 
We need to ensure that NeoGo VM behaviour is compatible, ref.
nspcc-dev/neo-go#3649.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva AnnaShaleva mentioned this pull request Oct 28, 2024
Merged
@shargon shargon merged commit 03ba1dc into master Oct 29, 2024
7 checks passed
@shargon shargon deleted the modpow-compat branch October 29, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

@cschuchardt88 cschuchardt88 cschuchardt88 approved these changes

@Jim8y Jim8y Jim8y approved these changes

@vncoelho vncoelho vncoelho approved these changes

@roman-khimov roman-khimov roman-khimov approved these changes

+1 more reviewer

@nan01ab nan01ab nan01ab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Ready to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@AnnaShaleva @shargon @cschuchardt88 @nan01ab @Jim8y @vncoelho @roman-khimov