Rename Identifier type to ElementId.
#37
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following up on #35, this renames the newly added
Identifiertype toElementId.Design considerations
This change follows a discussion in purescript-web/purescript-web-dom#57 where we decided on
ElementIdas the name for this type which I proposed should be added to that library.Future plans
My hope is for
web-domto own this type eventually, at which point Tecton can just re-export it similar toClassNameandAttrName.References
N/A
Code change checklist