Skip to content

Conversation

@nsaunders
Copy link
Owner

Description

  1. The CustomAttribute type and att constructor function have been removed in favor of the AttrName type from web-html.
  2. The &. operator (byClass function) no longer accepts a string argument. Instead, it requires a ClassName.
  3. The &# operator (byId function) no longer accepts a string argument. Instead, it requires a value of the newly-added Identifier type.

Design considerations

Future plans

Advocate for Identifier to be added to a purescript-web library so Tecton doesn't have to own it. See purescript-web/purescript-web-dom#57.

References

N/A

Code change checklist

  • Any new or updated functionality includes corresponding unit test coverage.
  • I have verified code formatting, run the unit tests, and checked for any changes in the examples.
  • I have added an entry to the Unreleased section of the CHANGELOG.

@nsaunders nsaunders force-pushed the feature/selector-types branch from ad4273b to 47e4124 Compare May 12, 2023 22:17
@nsaunders nsaunders merged commit 4cb5c88 into master May 12, 2023
@nsaunders nsaunders added enhancement New feature or request breaking Non-backward-compatible API change labels May 13, 2023
@nsaunders nsaunders deleted the feature/selector-types branch July 27, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Non-backward-compatible API change enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants