Stronger selector typing. Resolves #29. #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CustomAttributetype andattconstructor function have been removed in favor of theAttrNametype fromweb-html.&.operator (byClassfunction) no longer accepts a string argument. Instead, it requires aClassName.&#operator (byIdfunction) no longer accepts a string argument. Instead, it requires a value of the newly-addedIdentifiertype.Design considerations
ClassNameandAttrNametypes originated in Halogen and were ported toweb-html. Therefore, I would consider these "widely-recognized" types and their use (compared to bare strings) a best practice.attandkeyframesNamefunctions follows a change made in Halogen a long time ago related to theClassNametype. (See Drop keyframesName function, exposing KeyframesName constructor instead. #34 for further discussion.)&.operator: One less import and one less potentially confusing thing.Future plans
Advocate for
Identifierto be added to a purescript-web library so Tecton doesn't have to own it. See purescript-web/purescript-web-dom#57.References
N/A
Code change checklist