Skip to content

src: fix trace-event-file-pattern description #22683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: fix trace-event-file-pattern description #22683

wants to merge 1 commit into from

Conversation

@AndreasMadsen
Copy link
Member

Fix description for --trace-event-file-pattern in node --help. The %2$u option was from an old version that never got into master.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@AndreasMadsen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/788/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 4, 2018
@AndreasMadsen
Copy link
Member Author

AndreasMadsen commented Sep 4, 2018 •
edited
Loading

Ups. Was just preparing for a mini code-and-learn event in Copenhagen. I will make the real PR later today. Please don't merge this.

@richardlau
Copy link
Member

FYI there is already #22636 covering this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndreasMadsen @nodejs-github-bot @richardlau