Skip to content

Conversation

@addaleax
Copy link
Member

Refs: 85212bb#r30265305

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 31, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 1, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Sep 1, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/16918/ (:heavy_check_mark:)

@danbev
Copy link
Contributor

danbev commented Sep 5, 2018

Landed in 65f0323.

@danbev danbev closed this Sep 5, 2018
danbev pushed a commit that referenced this pull request Sep 5, 2018
PR-URL: #22636
Refs: https://github.com/nodejs/node/commit/
85212bb#r30265305
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@addaleax addaleax deleted the remove-2u branch September 5, 2018 09:24
targos pushed a commit that referenced this pull request Sep 5, 2018
PR-URL: #22636
Refs: https://github.com/nodejs/node/commit/
85212bb#r30265305
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Sep 6, 2018
PR-URL: #22636
Refs: https://github.com/nodejs/node/commit/
85212bb#r30265305
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants