Skip to content

Fix: tx.ToJson no 'cosigners' field #4051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025
Merged

Fix: tx.ToJson no 'cosigners' field #4051

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8f83b1
Fix: tx.ToJson no 'cosigners' field
Wi1l-B0t Jul 6, 2025
a52193a
Merge branch 'dev' into fix.tx-tojson-no-cosigners
Wi1l-B0t Jul 7, 2025
e2be08f
Rename methods
shargon Jul 7, 2025
74df979
Merge branch 'dev' into fix.tx-tojson-no-cosigners
Wi1l-B0t Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions benchmarks/Neo.Json.Benchmarks/Data/RpcTestCases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3628,7 +3628,7 @@
"netfee": "1272390",
"validuntilblock": 2105487,
"attributes": [],
"cosigners": [
"signers": [
{
"account": "0xcadb3dc2faa3ef14a13b619c9a43124755aa2569",
"scopes": "CalledByEntry"
Expand Down Expand Up @@ -3679,7 +3679,7 @@
"netfee": "2483780",
"validuntilblock": 2105494,
"attributes": [],
"cosigners": [
"signers": [
{
"account": "0x36d6200fb4c9737c7b552d2b5530ab43605c5869",
"scopes": "CalledByEntry"
Expand Down Expand Up @@ -3724,7 +3724,7 @@
"netfee": "2381780",
"validuntilblock": 2105500,
"attributes": [],
"cosigners": [
"signers": [
{
"account": "0xcadb3dc2faa3ef14a13b619c9a43124755aa2569",
"scopes": "CalledByEntry"
Expand Down
2 changes: 1 addition & 1 deletion src/Plugins/RpcServer/RpcServer.Wallet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ protected internal virtual JToken CalculateNetworkFee(JArray _params)
{
throw new RpcException(RpcError.InvalidParams.WithData("Params array is empty, need a raw transaction."));
}
var tx = Result.Ok_Or(() => Convert.FromBase64String(_params[0].AsString()), RpcError.InvalidParams.WithData($"Invalid tx: {_params[0]}")); ;
var tx = Result.Ok_Or(() => Convert.FromBase64String(_params[0].AsString()), RpcError.InvalidParams.WithData($"Invalid tx: {_params[0]}"));

JObject account = new();
var networkfee = Helper.CalculateNetworkFee(tx.AsSerializable<Transaction>(), system.StoreView, system.Settings, wallet);
Expand Down
6 changes: 3 additions & 3 deletions tests/Neo.Network.RPC.Tests/RpcTestCases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3628,7 +3628,7 @@
"netfee": "1272390",
"validuntilblock": 2105487,
"attributes": [],
"cosigners": [
"signers": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this worked? Is this json processed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this worked? Is this json processed?

I don't know.
Maybe not check this.

{
"account": "0xcadb3dc2faa3ef14a13b619c9a43124755aa2569",
"scopes": "CalledByEntry"
Expand Down Expand Up @@ -3679,7 +3679,7 @@
"netfee": "2483780",
"validuntilblock": 2105494,
"attributes": [],
"cosigners": [
"signers": [
{
"account": "0x36d6200fb4c9737c7b552d2b5530ab43605c5869",
"scopes": "CalledByEntry"
Expand Down Expand Up @@ -3724,7 +3724,7 @@
"netfee": "2381780",
"validuntilblock": 2105500,
"attributes": [],
"cosigners": [
"signers": [
{
"account": "0xcadb3dc2faa3ef14a13b619c9a43124755aa2569",
"scopes": "CalledByEntry"
Expand Down
56 changes: 24 additions & 32 deletions tests/Neo.UnitTests/Network/P2P/Payloads/UT_Transaction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,9 +872,8 @@ public void Transaction_Serialize_Deserialize_Simple()
[TestMethod]
public void Transaction_Serialize_Deserialize_DistinctCosigners()
{
// cosigners must be distinct (regarding account)

Transaction txDoubleCosigners = new()
// the `Signers` must be distinct (regarding account)
var txDoubleSigners = new Transaction
{
Version = 0x00,
Nonce = 0x01020304,
Expand All @@ -899,14 +898,14 @@ public void Transaction_Serialize_Deserialize_DistinctCosigners()
Witnesses = [Witness.Empty]
};

var sTx = txDoubleCosigners.ToArray();
var sTx = txDoubleSigners.ToArray();

// no need for detailed hexstring here (see basic tests for it)
var expected = "000403020100e1f50500000000010000000000000004030201020908070605040302010009080706050403020" +
"10080090807060504030201000908070605040302010001000111010000";
Assert.AreEqual(expected, sTx.ToHexString());

// back to transaction (should fail, due to non-distinct cosigners)
// back to transaction (should fail, due to non-distinct signers)
Transaction tx2 = null;
Assert.ThrowsExactly<FormatException>(() => _ = tx2 = sTx.AsSerializable<Transaction>());
Assert.IsNull(tx2);
Expand All @@ -916,99 +915,92 @@ public void Transaction_Serialize_Deserialize_DistinctCosigners()
[TestMethod]
public void Transaction_Serialize_Deserialize_MaxSizeCosigners()
{
// cosigners must respect count

int maxCosigners = 16;
// the `Signers` must respect count
int maxSigners = 16;

// --------------------------------------
// this should pass (respecting max size)

var cosigners1 = new Signer[maxCosigners];
for (int i = 0; i < cosigners1.Length; i++)
var signers1 = new Signer[maxSigners];
for (int i = 0; i < signers1.Length; i++)
{
string hex = i.ToString("X4");
while (hex.Length < 40)
hex = hex.Insert(0, "0");
cosigners1[i] = new Signer
signers1[i] = new Signer
{
Account = UInt160.Parse(hex),
Scopes = WitnessScope.CalledByEntry
};
}

Transaction txCosigners1 = new()
var txSigners1 = new Transaction
{
Version = 0x00,
Nonce = 0x01020304,
SystemFee = (long)BigInteger.Pow(10, 8), // 1 GAS
NetworkFee = 0x0000000000000001,
ValidUntilBlock = 0x01020304,
Attributes = [],
Signers = cosigners1, // max + 1 (should fail)
Signers = signers1, // max + 1 (should fail)
Script = new[] { (byte)OpCode.PUSH1 },
Witnesses = [Witness.Empty]
};

byte[] sTx1 = txCosigners1.ToArray();
var sTx1 = txSigners1.ToArray();

// back to transaction (should fail, due to non-distinct cosigners)
// back to transaction (should fail, due to non-distinct signers)
Assert.ThrowsExactly<FormatException>(() => _ = sTx1.AsSerializable<Transaction>());

// ----------------------------
// this should fail (max + 1)

var cosigners = new Signer[maxCosigners + 1];
for (var i = 0; i < maxCosigners + 1; i++)
var signers = new Signer[maxSigners + 1];
for (var i = 0; i < maxSigners + 1; i++)
{
var hex = i.ToString("X4");
while (hex.Length < 40)
hex = hex.Insert(0, "0");
cosigners[i] = new Signer
signers[i] = new Signer
{
Account = UInt160.Parse(hex)
};
}

Transaction txCosigners = new()
var txSigners = new Transaction
{
Version = 0x00,
Nonce = 0x01020304,
SystemFee = (long)BigInteger.Pow(10, 8), // 1 GAS
NetworkFee = 0x0000000000000001,
ValidUntilBlock = 0x01020304,
Attributes = [],
Signers = cosigners, // max + 1 (should fail)
Signers = signers, // max + 1 (should fail)
Script = new[] { (byte)OpCode.PUSH1 },
Witnesses = [Witness.Empty]
};

byte[] sTx2 = txCosigners.ToArray();
var sTx2 = txSigners.ToArray();

// back to transaction (should fail, due to non-distinct cosigners)
// back to transaction (should fail, due to non-distinct signers)
Transaction tx2 = null;
Assert.ThrowsExactly<FormatException>(() => _ = tx2 = sTx2.AsSerializable<Transaction>()
);
Assert.ThrowsExactly<FormatException>(() => _ = tx2 = sTx2.AsSerializable<Transaction>());
Assert.IsNull(tx2);
}

[TestMethod]
public void FeeIsSignatureContract_TestScope_FeeOnly_Default()
{
// Global is supposed to be default

Signer cosigner = new();
Assert.AreEqual(WitnessScope.None, cosigner.Scopes);
var signer = new Signer();
Assert.AreEqual(WitnessScope.None, signer.Scopes);

var wallet = TestUtils.GenerateTestWallet("");
var snapshotCache = TestBlockchain.GetTestSnapshotCache();
var acc = wallet.CreateAccount();

// Fake balance

var key = NativeContract.GAS.CreateStorageKey(20, acc.ScriptHash);

var entry = snapshotCache.GetAndChange(key, () => new StorageItem(new AccountState()));

entry.GetInteroperable<AccountState>().Balance = 10000 * NativeContract.GAS.Factor;

snapshotCache.Commit();
Expand All @@ -1017,7 +1009,7 @@ public void FeeIsSignatureContract_TestScope_FeeOnly_Default()
// Manually creating script

byte[] script;
using (ScriptBuilder sb = new())
using (var sb = new ScriptBuilder())
{
// self-transfer of 1e-8 GAS
BigInteger value = new BigDecimal(BigInteger.One, 8).Value;
Expand Down