Fix: tx.ToJson no 'cosigners' field

[Wi1l-B0t]

Description

Transaction.ToJson no cosigners field.
The field is signers', not cosigners,

neo/src/Neo/Network/P2P/Payloads/Transaction.cs

Lines 329 to 344 in 9b9be47

	public JObject ToJson(ProtocolSettings settings)
	{
	JObject json = new();
	json["hash"] = Hash.ToString();
	json["size"] = Size;
	json["version"] = Version;
	json["nonce"] = Nonce;
	json["sender"] = Sender.ToAddress(settings.AddressVersion);
	json["sysfee"] = SystemFee.ToString();
	json["netfee"] = NetworkFee.ToString();
	json["validuntilblock"] = ValidUntilBlock;
	json["signers"] = Signers.Select(p => p.ToJson()).ToArray();
	json["attributes"] = Attributes.Select(p => p.ToJson()).ToArray();
	json["script"] = Convert.ToBase64String(Script.Span);
	json["witnesses"] = Witnesses.Select(p => p.ToJson()).ToArray();
	return json;

Type of change

• Optimization (the change is only an optimization)
• Style (the change is only a code style for better maintenance or standard purpose)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[shargon]

Why this worked? Is this json processed?

[Wi1l-B0t]

Why this worked? Is this json processed?

I don't know.
Maybe not check this.

[shargon]

We should deep into this, it seems that those files are not used

[Wi1l-B0t]

We should deep into this, it seems that those files are not used

These files are used, but something not checked.

[vncoelho]

We should deep into this, it seems that those files are not used

These files are used, but something not checked.

I checked the asset and they provide

{{"hash":"0x035facc3be1fc57da1690e3d2f8214f449d368437d8557ffabb2d408caf9ad76","size":272,"version":0,"nonce":1553700339,"sender":"NVVwFw6XyhtRCFQ8SpUTMdPyYt4Vd9A1XQ","sysfee":"100000000","netfee":"1272390","validuntilblock":2105487,"attributes":[],"cosigners":[{"account":"0xcadb3dc2faa3ef14a13b619c9a43124755aa2569","scopes":"CalledByEntry"}],"script":"A\u002BCSx1QCAAAADBSZA7DD0pKYj\u002Bvl8wagL2VOousWKQwUaSWqVUcSQ5qcYTuhFO\u002Bj\u002BsI928oTwAwIdHJhbnNmZXIMFDt9NxHG8Mz5sdypA9G/odiW8SOMQWJ9W1I5","witnesses":[{"invocation":"DEDOA/QF5jYT2TCl9T94fFwAncuBhVhciISaq4fZ3WqGarEoT/0iDo3RIwGjfRW0mm/SV3nAVGEQeZInLqKQ98HX","verification":"DCEDqgUvvLjlszpO79ZiU2\u002BGhGQfBBCfHV5pzdpvCEiQKGoLQQqQatQ="}]}}

From here

        public async Task TestSendFrom()
        {
            var test = TestUtils.RpcTestCases.Find(p => p.Name == nameof(rpc.SendFromAsync).ToLower());
            var result = await rpc.SendFromAsync(test.Request.Params[0].AsString(), test.Request.Params[1].AsString(),
                test.Request.Params[2].AsString(), test.Request.Params[3].AsString());
            Assert.AreEqual(test.Response.Result.ToString(), result.ToString());
        }

[vncoelho]

@shargon @Wi1l-B0t

[Wi1l-B0t]

@shargon @Wi1l-B0t

Because the returned result is mocked.

UT_RpcClient.cs Line 49

private void MockResponse(RpcRequest request, RpcResponse response)

[vncoelho]

Is the returned result is mocked the test is really not useful as it is...aheuahea