[Neo VM] adopt light gc from neogo(reopen) #3693

superboyiii · 2025-01-23T10:52:54Z

Description

from #3581. I reopened this for @Jim8y to master

Fixes # (issue)

Type of change

Optimization (the change is only an optimization)
Style (the change is only a code style for better maintenance or standard purpose)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Test A
Test B

Test Configuration:

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

* Add entries to Designation event * Change to HF_Echidna * Add UT * Add count

* add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead.

* Add entries to Designation event * Change to HF_Echidna * Add UT * Add count

* add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead.

# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

* Add entries to Designation event * Change to HF_Echidna * Add UT * Add count

* add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead.

# Conflicts: # src/Neo/Neo.csproj # src/Neo/SmartContract/Native/RoleManagement.cs

…ange. and add hardfork

* fix: int overflow in SubStr * fix: int overflow in SubStr * format * Versioning change * Clean * Rename * Show change * Space * remove duplicated lines in gitignroe --------- Co-authored-by: Jimmy <[email protected]> Co-authored-by: Shargon <[email protected]>

* Allow callstates to use HF * Rename to method * Other rename * Change the way * Reduce changes * Reduce changes * Adapt name always * Avoid string when only is lower the first char * UT * Test all * Update src/Neo/ProtocolSettings.cs Co-authored-by: Christopher Schuchardt <[email protected]> * Update src/Neo/ProtocolSettings.cs Co-authored-by: Christopher Schuchardt <[email protected]> * Reuse Load from stream * Unify * Fix default logic * Change ContractMethod to allowMultiple * Use LowerInvariant * Move CheckingHardfork * Remove optional arg * Fix build * Avoid file not found error --------- Co-authored-by: Christopher Schuchardt <[email protected]>

* fux build error * Update src/Neo/SmartContract/ApplicationEngine.cs --------- Co-authored-by: Shargon <[email protected]>

Co-authored-by: nan01ab <[email protected]>

Co-authored-by: Hecate2 <[email protected]>

* master: (43 commits) Fix `GetAndChange` warnings (neo-project#3702) `Murmur3` should not be cryptographic hash algorithm (neo-project#3668) Test: add tests for native contract id (neo-project#3697) Update nugets (neo-project#3692) [Core P2P] fix the bug (neo-project#3695) Add hardfork HF_Echidna (neo-project#3454) Fix: add lock for RocksDbStore.Snapshot to keep same behavior as MemoryStore and LevelDbStore (neo-project#3689) Nullable rocks db (neo-project#3686) Nullable leveldb (neo-project#3685) Enforcement Compiler Warnings (neo-project#3687) [`Update`] Dotnet & Compiler Version (neo-project#3684) [`Add`]: LevelDB Benchmarks (neo-project#3667) [`Fix`]: Behavior when `keyPrefix` is null in different `IStore.Seek` impls. (neo-project#3682) Improve calculatenetworkfee (neo-project#3674) more 2025 (neo-project#3678) Nullable in Storage classes (neo-project#3670) readonly (neo-project#3676) [Fix] Set max entries for `VerifyProof` in `statePlugin` (neo-project#3675) Neo.json.benchmarks (neo-project#3673) Happy new year 2025 (neo-project#3677) ... # Conflicts: # src/Neo/Neo.csproj # src/Neo/ProtocolSettings.cs # src/Neo/SmartContract/ApplicationEngine.cs # src/Neo/SmartContract/Native/NeoToken.cs # src/Neo/SmartContract/Native/RoleManagement.cs # tests/Neo.UnitTests/SmartContract/Native/UT_NativeContract.cs

Wi1l-B0t · 2025-06-28T16:31:38Z

Please make progress on this.

cschuchardt88 · 2025-09-22T19:48:04Z

@Wi1l-B0t

Please make progress on this.

Be my guess. Its up for grabs.

shargon · 2025-10-02T08:15:21Z

Please make progress on this.

As defined in #4198 Maybe if we change to a different VM we can remove the ReferenceCounter, this will increase the speed a lot.

@erikzhang do you think that we will need a RC in the new VM?

erikzhang · 2025-10-10T02:53:38Z

Closed due to non-NEO4 priority.

Jimmy and others added 30 commits August 8, 2024 00:24

add hardofork HF_Echidna

bcc5fd0

Add entries to Designation event (neo-project#3397)

e63f10b

* Add entries to Designation event * Change to HF_Echidna * Add UT * Add count

[Neo Core StdLib] Add Base64url (neo-project#3453)

9d16c53

* add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead.

add hardofork HF_Echidna

f746f8d

Add entries to Designation event (neo-project#3397)

8d7f9e8

* Add entries to Designation event * Change to HF_Echidna * Add UT * Add count

[Neo Core StdLib] Add Base64url (neo-project#3453)

3fc8077

* add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead.

add hardofork HF_Echidna

7e31d0c

Add entries to Designation event (neo-project#3397)

993e3fe

* Add entries to Designation event * Change to HF_Echidna * Add UT * Add count

[Neo Core StdLib] Add Base64url (neo-project#3453)

37bf0cb

* add base64url * active in * update placehold hf height * fix hf issue and move methods to proper place. * fix test * use identifymodel instead.

format

7dba130

Merge branch 'HF_Echidna' of github.com:neo-project/neo into HF_Echidna

0457ccd

# Conflicts: # src/Neo/Neo.csproj # src/Neo/SmartContract/Native/RoleManagement.cs

adopt light gc

afa99ca

format

a6b3f69

fix building issue in benchmark

4874a6e

fix popitem

a8fd587

revert change

4de3809

revert to fix compatibillity

d7cde61

Merge Master

d7a291e

Fixed typo

6e780c0

Added back neo-project#3397

02d6ab9

Fixed tests

8fb30df

fixed global.json

f9244eb

Merge branch 'HF_Echidna' into rc-v2

e9061e5

adopt new solution as using null rc, instead of making large scale ch…

5d9d7c4

…ange. and add hardfork

avoid change that is currently not necessary

0ccd831

revert null default

fc8df97

revert null default

6acfc2c

revert null

2d6deab

apply compound update and apply hardfork

6200bdb

cschuchardt88 and others added 15 commits December 4, 2024 02:55

Merge branch 'master' into HF_Echidna

577c431

Update src/Neo/Neo.csproj

1c82ed9

Update src/Neo/Neo.csproj

b81b127

Merge branch 'master' into HF_Echidna

a3a6fd5

Merge branch 'master' into HF_Echidna

c086661

Merge branch 'master' into HF_Echidna

0f1507f

Merge branch 'master' into HF_Echidna

498ed91

Merge branch 'master' into HF_Echidna

08c3be6

fix tests error (neo-project#3636)

59fe8b5

* fux build error * Update src/Neo/SmartContract/ApplicationEngine.cs --------- Co-authored-by: Shargon <[email protected]>

Merge branch 'HF_Echidna' into rc-v2

dbf054d

Update src/Neo.VM/ReferenceCounter/ReferenceCounterV2.cs

6dbc104

Co-authored-by: nan01ab <[email protected]>

Update src/Neo.VM/ReferenceCounter/ReferenceCounterV2.cs

552991f

Co-authored-by: nan01ab <[email protected]>

Update src/Neo.VM/ReferenceCounter/ReferenceCounterV2.cs

95f6535

Co-authored-by: Hecate2 <[email protected]>

roman-khimov added this to the v3.8.0 milestone Jan 23, 2025

cschuchardt88 added the Need Update label Jan 31, 2025

Jim8y modified the milestones: v3.8.0, v3.9.0 Feb 10, 2025

roman-khimov modified the milestones: v3.9.0, v3.8.0 Feb 13, 2025

roman-khimov modified the milestones: v3.8.0, v3.9.0 May 5, 2025

roman-khimov mentioned this pull request Jun 27, 2025

Fix: wrong reference count after invalid Map[key] = value #4027

Closed

14 tasks

erikzhang closed this Oct 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Neo VM] adopt light gc from neogo(reopen) #3693

[Neo VM] adopt light gc from neogo(reopen) #3693

Uh oh!

superboyiii commented Jan 23, 2025

Uh oh!

Wi1l-B0t commented Jun 28, 2025

Uh oh!

cschuchardt88 commented Sep 22, 2025

Uh oh!

shargon commented Oct 2, 2025 •

edited

Loading

Uh oh!

erikzhang commented Oct 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

[Neo VM] adopt light gc from neogo(reopen) #3693

[Neo VM] adopt light gc from neogo(reopen) #3693

Uh oh!

Conversation

superboyiii commented Jan 23, 2025

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

Wi1l-B0t commented Jun 28, 2025

Uh oh!

cschuchardt88 commented Sep 22, 2025

Uh oh!

shargon commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erikzhang commented Oct 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

shargon commented Oct 2, 2025 •

edited

Loading