Skip to content

Conversation

@shargon
Copy link
Member

@shargon shargon commented Jul 4, 2024

Description

Wait for more methods to create a new fork
Require #3362
Close #3389

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Pending

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon added Blocked This issue can't be worked at the moment Waiting-Hardfork labels Jul 4, 2024
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be nice to have a unit-test.

@shargon
Copy link
Member Author

shargon commented Jul 5, 2024

The ut added also test that #3362 works fine :)

@shargon shargon marked this pull request as ready for review July 5, 2024 07:41
@shargon shargon changed the title Add entries to Designation event Add entries to Designation event Jul 5, 2024
@Jim8y
Copy link
Contributor

Jim8y commented Jul 30, 2024

@shargon how about this pr? will need the hardfork somewhere else.

@vncoelho
Copy link
Member

I think this is worth proceeding.

@shargon
Copy link
Member Author

shargon commented Jul 30, 2024

@shargon how about this pr? will need the hardfork somewhere else.

Is waiting for more features in the same hardfork

@Jim8y
Copy link
Contributor

Jim8y commented Jul 31, 2024

@shargon how about this pr? will need the hardfork somewhere else.

Is waiting for more features in the same hardfork

I mean just create a pr that adds the hardfork, having a hardfork name will not cause any problem.

@Jim8y
Copy link
Contributor

Jim8y commented Jul 31, 2024

BTW, please resolve conflicts.

@shargon
Copy link
Member Author

shargon commented Jul 31, 2024

Also we can merge this, and not configure the HF, the feature will come with others when the HF is configured

@Jim8y Jim8y mentioned this pull request Aug 7, 2024
11 tasks
@Jim8y Jim8y changed the base branch from master to HF_Echidna August 7, 2024 16:28
@superboyiii
Copy link
Member

Test: PASS
Before HF_Echidna:

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": {
        "txid": "0xd7039f3f8317b461097ca1ff393f3f39b5ea05276c790603b703b44e40784421",
        "executions": [
            {
                "trigger": "Application",
                "vmstate": "HALT",
                "exception": null,
                "gasconsumed": "2090550",
                "stack": [
                    {
                        "type": "Any"
                    }
                ],
                "notifications": [
                    {
                        "contract": "0x49cf4e5378ffcd4dec034fd98a174c5491e395e2",
                        "eventname": "Designation",
                        "state": {
                            "type": "Array",
                            "value": [
                                {
                                    "type": "Integer",
                                    "value": "4"
                                },
                                {
                                    "type": "Integer",
                                    "value": "42"
                                }
                            ]
                        }
                    }
                ]
            }
        ]
    }
}

After HF_Echidna:

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": {
        "txid": "0x08a54e3183a2dd0f1e88303080b0b52d105a92c640c5504240d8863f1b14ea6b",
        "executions": [
            {
                "trigger": "Application",
                "vmstate": "HALT",
                "exception": null,
                "gasconsumed": "2090550",
                "stack": [
                    {
                        "type": "Any"
                    }
                ],
                "notifications": [
                    {
                        "contract": "0x49cf4e5378ffcd4dec034fd98a174c5491e395e2",
                        "eventname": "Designation",
                        "state": {
                            "type": "Array",
                            "value": [
                                {
                                    "type": "Integer",
                                    "value": "4"
                                },
                                {
                                    "type": "Integer",
                                    "value": "61"
                                },
                                {
                                    "type": "Array",
                                    "value": [
                                        {
                                            "type": "ByteString",
                                            "value": "AhJGxC9c3mJD/hg7FDYdohTlmdGyXPQoIA9kYK6qdBvh"
                                        },
                                        {
                                            "type": "ByteString",
                                            "value": "AyHoH24FT3hSY3V9CZUzX1bSfJoXCfvds2sNNxVK6Boj"
                                        },
                                        {
                                            "type": "ByteString",
                                            "value": "A111yY9zJv/n6nJrdzJbl7wG2NAIqzTZV1DJ22jYIMSP"
                                        },
                                        {
                                            "type": "ByteString",
                                            "value": "A3briYQGk9je1GivNmTbNp0Av+2iHO7vFhX1Z66AzCMu"
                                        }
                                    ]
                                },
                                {
                                    "type": "Array",
                                    "value": [
                                        {
                                            "type": "ByteString",
                                            "value": "AxLpQlEVqhOWOqj0n3lsbSsjCHmuqD4XRYOHidQpCvwQ"
                                        },
                                        {
                                            "type": "ByteString",
                                            "value": "AtbQ1aBGz24M4yvvNg+DNdAulA9//3VwKb2MTSyHgAGD"
                                        },
                                        {
                                            "type": "ByteString",
                                            "value": "ArNnumlmTbihVD7I/jiNjx1Gl9SU/TZA+lRivjqm7Y9K"
                                        },
                                        {
                                            "type": "ByteString",
                                            "value": "AlT/v0cbtmoZSJu6jfuPyMYo/lHralETJfkny2c5REB7"
                                        }
                                    ]
                                }
                            ]
                        }
                    }
                ]
            }
        ]
    }
}

@shargon
Copy link
Member Author

shargon commented Aug 8, 2024

Merged into HF_Echidna

@shargon shargon merged commit e63f10b into HF_Echidna Aug 8, 2024
@shargon shargon deleted the designation-event branch August 8, 2024 08:54
Jim8y pushed a commit that referenced this pull request Oct 2, 2024
* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count
Jim8y pushed a commit that referenced this pull request Nov 6, 2024
* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count
Jim8y pushed a commit that referenced this pull request Nov 17, 2024
* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count
Jim8y pushed a commit that referenced this pull request Nov 17, 2024
* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count
Jim8y pushed a commit that referenced this pull request Nov 17, 2024
* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count
cschuchardt88 added a commit that referenced this pull request Nov 17, 2024
NGDAdmin pushed a commit that referenced this pull request Jan 23, 2025
* add hardofork HF_Echidna

* Add entries to `Designation` event (#3397)

* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count

* [Neo Core StdLib] Add Base64url (#3453)

* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.

* add hardofork HF_Echidna

* Add entries to `Designation` event (#3397)

* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count

* [Neo Core StdLib] Add Base64url (#3453)

* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.

* add hardofork HF_Echidna

* Add entries to `Designation` event (#3397)

* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count

* [Neo Core StdLib] Add Base64url (#3453)

* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.

* format

* Fixed typo

* Added back #3397

* Fixed tests

* fixed global.json

* Update src/Neo/Neo.csproj

* Update src/Neo/Neo.csproj

* [`Fix`]: integer overflow in `JumpTable.SubStr ` (#3496)

* fix: int overflow in SubStr

* fix: int overflow in SubStr

* format

* Versioning change

* Clean

* Rename

* Show change

* Space

* remove duplicated lines in gitignroe

---------

Co-authored-by: Jimmy <[email protected]>
Co-authored-by: Shargon <[email protected]>

* Fix NEO callstates (#3599)

* Allow callstates to use HF

* Rename to method

* Other rename

* Change the way

* Reduce changes

* Reduce changes

* Adapt name always

* Avoid string when only is lower the first char

* UT

* Test all

* Update src/Neo/ProtocolSettings.cs

Co-authored-by: Christopher Schuchardt <[email protected]>

* Update src/Neo/ProtocolSettings.cs

Co-authored-by: Christopher Schuchardt <[email protected]>

* Reuse Load from stream

* Unify

* Fix default logic

* Change ContractMethod to allowMultiple

* Use LowerInvariant

* Move CheckingHardfork

* Remove optional arg

* Fix build

* Avoid file not found error

---------

Co-authored-by: Christopher Schuchardt <[email protected]>

* fix tests error (#3636)

* fux build error

* Update src/Neo/SmartContract/ApplicationEngine.cs

---------

Co-authored-by: Shargon <[email protected]>

* NeoToken: accept candidate registration via onNEP17Payment (#3597)

Solves two problems:
 * inability to estimate GAS needed for registerCandidate in a regular way
   because of its very high fee (more than what normal RPC servers allow)
 * inability to have MaxBlockSystemFee lower than the registration price
   which is very high on its own (more than practically possible to execute)

Fixes #3552.

Signed-off-by: Roman Khimov <[email protected]>

* specify the argument exception information.

* Fix Ut (#3635)

* NeoToken: add NEP-27 to supported standards list starting from Echidna (#3643)

#3597 introduces `onNEP17Payment`
handler to native NeoToke contract starting from Echidna hardfork. We
need to update the list of supported standards respectively.

Signed-off-by: Anna Shaleva <[email protected]>

* ut: fix HF_Echidna unit tests (#3646)

* Fix UT

* Update src/Neo/ProtocolSettings.cs

Co-authored-by: nan01ab <[email protected]>

* Update src/Neo/ProtocolSettings.cs

Co-authored-by: nan01ab <[email protected]>

* Update src/Neo/ProtocolSettings.cs

Co-authored-by: Christopher Schuchardt <[email protected]>

---------

Co-authored-by: Jimmy <[email protected]>
Co-authored-by: nan01ab <[email protected]>
Co-authored-by: Christopher Schuchardt <[email protected]>

* [Core Add] Add support to Ed25519 (#3507)

* fix unnecessary change

* Clean using

---------

Co-authored-by: Fernando Diaz Toledano <[email protected]>

* Fix `HF_Echidna` comments (#3679)

* Fix obsolete

* Fix https://github.com/neo-project/neo/pull/3454/files#r1912152270

* Fix comment

* Update RoleManagement.cs

* Unset HF_Echidna

* Revert getTransaction

* Revert verifyWithECDsa

* format

---------

Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Anna Shaleva <[email protected]>
Co-authored-by: Shargon <[email protected]>
Co-authored-by: Christopher Schuchardt <[email protected]>
Co-authored-by: nan01ab <[email protected]>
Co-authored-by: Roman Khimov <[email protected]>
Co-authored-by: Anna Shaleva <[email protected]>
Co-authored-by: Vitor Nazário Coelho <[email protected]>
NGDAdmin added a commit that referenced this pull request Mar 5, 2025
* add hardofork HF_Echidna

* Add entries to `Designation` event (#3397)

* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count

* [Neo Core StdLib] Add Base64url (#3453)

* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.

* add hardofork HF_Echidna

* Add entries to `Designation` event (#3397)

* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count

* [Neo Core StdLib] Add Base64url (#3453)

* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.

* SmartContract: restrict the number of allowed notifications

Fix the problem described in
nspcc-dev/neo-go#3490. Port the solution from
nspcc-dev/neo-go#3640.

MaxNotificationsCount constraint is chosen based on the Mainnet
statistics of the number of notifications per every transaction, ref.
nspcc-dev/neo-go#3490 (comment).

Signed-off-by: Anna Shaleva <[email protected]>

* SmartContract: fix format

Signed-off-by: Anna Shaleva <[email protected]>

* Update src/Neo/SmartContract/ApplicationEngine.Runtime.cs

* Avoid notification creation

* add hardofork HF_Echidna

* Add entries to `Designation` event (#3397)

* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count

* [Neo Core StdLib] Add Base64url (#3453)

* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.

* format

* Fixed typo

* Added back #3397

* fix format

* Update src/Neo/SmartContract/Native/RoleManagement.cs

* Neo.CLI: revert configuration changes

Signed-off-by: Anna Shaleva <[email protected]>

---------

Signed-off-by: Anna Shaleva <[email protected]>
Co-authored-by: Jimmy <[email protected]>
Co-authored-by: Shargon <[email protected]>
Co-authored-by: Christopher Schuchardt <[email protected]>
Co-authored-by: NGD Admin <[email protected]>
cschuchardt88 added a commit to cschuchardt88/neo that referenced this pull request Jun 8, 2025
…ect#3548)

* add hardofork HF_Echidna

* Add entries to `Designation` event (neo-project#3397)

* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count

* [Neo Core StdLib] Add Base64url (neo-project#3453)

* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.

* add hardofork HF_Echidna

* Add entries to `Designation` event (neo-project#3397)

* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count

* [Neo Core StdLib] Add Base64url (neo-project#3453)

* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.

* SmartContract: restrict the number of allowed notifications

Fix the problem described in
nspcc-dev/neo-go#3490. Port the solution from
nspcc-dev/neo-go#3640.

MaxNotificationsCount constraint is chosen based on the Mainnet
statistics of the number of notifications per every transaction, ref.
nspcc-dev/neo-go#3490 (comment).

Signed-off-by: Anna Shaleva <[email protected]>

* SmartContract: fix format

Signed-off-by: Anna Shaleva <[email protected]>

* Update src/Neo/SmartContract/ApplicationEngine.Runtime.cs

* Avoid notification creation

* add hardofork HF_Echidna

* Add entries to `Designation` event (neo-project#3397)

* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count

* [Neo Core StdLib] Add Base64url (neo-project#3453)

* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.

* format

* Fixed typo

* Added back neo-project#3397

* fix format

* Update src/Neo/SmartContract/Native/RoleManagement.cs

* Neo.CLI: revert configuration changes

Signed-off-by: Anna Shaleva <[email protected]>

---------

Signed-off-by: Anna Shaleva <[email protected]>
Co-authored-by: Jimmy <[email protected]>
Co-authored-by: Shargon <[email protected]>
Co-authored-by: Christopher Schuchardt <[email protected]>
Co-authored-by: NGD Admin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocked This issue can't be worked at the moment Hardfork

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend Designated native RoleManagement events with old/new public keys

6 participants