Skip to content

Hide gallery section if no exhibits are configured #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Hide gallery section if no exhibits are configured #2549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8eb5b8
Add `hide_gallery_without_exhibits` default and option
krassowski Jun 28, 2024
e4dbf22
Merge branch 'develop' into hide-if-no-exhibits
krassowski Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/_nebari/stages/kubernetes_services/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ class JupyterLabGallerySettings(schema.Base):
title: str = "Examples"
destination: str = "examples"
exhibits: List[JupyterLabGalleryExhibit] = []
hide_gallery_without_exhibits: bool = True


class JupyterLab(schema.Base):
Expand Down
5 changes: 3 additions & 2 deletions src/_nebari/stages/kubernetes_services/template/jupyterhub.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,9 @@ variable "jupyterlab-default-settings" {
variable "jupyterlab-gallery-settings" {
description = "Server-side settings for jupyterlab-gallery extension"
type = object({
title = optional(string)
destination = optional(string)
title = optional(string)
destination = optional(string)
hide_gallery_without_exhibits = optional(bool)
exhibits = list(object({
git = string
title = string
Expand Down
5 changes: 3 additions & 2 deletions ...i/stages/kubernetes_services/template/modules/kubernetes/services/jupyterhub/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,9 @@ variable "jupyterlab-default-settings" {
variable "jupyterlab-gallery-settings" {
description = "Server-side settings for jupyterlab-gallery extension"
type = object({
title = optional(string)
destination = optional(string)
title = optional(string)
destination = optional(string)
hide_gallery_without_exhibits = optional(bool)
exhibits = list(object({
git = string
title = string
Expand Down