Skip to content

Hide gallery section if no exhibits are configured #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2024
Merged

Hide gallery section if no exhibits are configured #2549

merged 2 commits into from
Jul 23, 2024

Conversation

@krassowski
Copy link
Member

@krassowski krassowski commented Jun 28, 2024

Reference Issues or PRs

Accompanies nebari-dev/jupyterlab-gallery#20

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@krassowski
Copy link
Member Author

krassowski commented Jul 2, 2024

I'm not sure why CI failed here, I re-triggered it.

@krassowski krassowski marked this pull request as ready for review July 5, 2024 13:51
@marcelovilla marcelovilla added this to the 2024.7.1 milestone Jul 5, 2024
@kcpevey kcpevey added the needs: review 👀 This PR is complete and ready for reviewing label Jul 22, 2024
marcelovilla
marcelovilla approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krassowski !

@krassowski krassowski merged commit cdd7cf9 into nebari-dev:develop Jul 23, 2024
Adam-D-Lewis pushed a commit that referenced this pull request Jul 30, 2024
@krassowski @Adam-D-Lewis
Hide gallery section if no exhibits are configured (#2549)
b6be83a
Adam-D-Lewis added a commit that referenced this pull request Jul 30, 2024
@Adam-D-Lewis
Revert "Hide gallery section if no exhibits are configured (#2549)"
8fb2be3 
This reverts commit b6be83a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelovilla marcelovilla marcelovilla approved these changes

Assignees

No one assigned

Labels

needs: review 👀 This PR is complete and ready for reviewing

Projects

🪴 Nebari Project Management
Archived in project

Milestone

2024.7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@krassowski @marcelovilla @kcpevey