'Musical symbols scale' option #20934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its-not-nice
requested review from
its-not-nice
and removed request for
bkunda
XiaoMigros
force-pushed
the
musical-symbols-scale
branch
from
2e86ebd to
fc911cb
Compare
XiaoMigros
force-pushed
the
musical-symbols-scale
branch
from
fc911cb to
2eceb22
Compare
Contributor
|
Saving
instead of
doesn't seem to be a good idea. |
Contributor
Author
|
The utests agree with you! A more elegant solution is underway... |
XiaoMigros
force-pushed
the
musical-symbols-scale
branch
22 times, most recently
from
c5e793a to
f83b86e
Compare
XiaoMigros
force-pushed
the
musical-symbols-scale
branch
6 times, most recently
from
a35a16d to
84bf2a6
Compare
its-not-nice
approved these changes
Feb 7, 2024
mike-spa
approved these changes
Feb 7, 2024
bkunda
approved these changes
Feb 7, 2024
cbjeukendrup
approved these changes
Feb 9, 2024
Member
cbjeukendrup
left a comment
cbjeukendrup
left a comment
There was a problem hiding this comment.
Some tiny almost-optional comments but for the rest this looks good to me!
XiaoMigros
force-pushed
the
musical-symbols-scale
branch
from
84bf2a6 to
b74cd21
Compare
XiaoMigros
force-pushed
the
musical-symbols-scale
branch
from
b74cd21 to
3f0785e
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #20772
Resolves: #19366
Resolves: #17885
This PR changes the following: