-
Notifications
You must be signed in to change notification settings - Fork 3k
'Musical symbols scale' option & more #20772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
30e90d2 to
72a4765
Compare
|
It should, but it also needs to have a 'Scale' parameter for when people resize them (where the default 100% = 20pt) - like how dynamics now work. When we did dynamics we removed the 'Dynamics' text style (so all settings are now in Style > Dynamics) but we can't do that here because we need to keep the option to use any text font for tuplets. So there's a design question about how to arrange these settings, which are now split between Style > Tuplets and Style > Text styles > Tuplet. |
|
FWIW, the scale is still influenced by the font size. |
|
Well it shouldn't, and I've just finished writing my comment about that on the other PR |
c8c4f00 to
44b2f1b
Compare
7031885 to
b4ef824
Compare
b4ef824 to
08b5445
Compare
08b5445 to
519a7ad
Compare
|
Needs rebasing, closing... |
|
You can rebase without closing: |
|
It changed my commit order, and as a consequence I could no longer force push the actual changes to the same commit as I had been doing previously. |
|
It doesn't really matter at all, but just as a hint for the future: force-pushing is something you do with a branch, not with a commit. What you probably mean is that you wanted to amend the same commit again and again. Indeed, amending the last commit is easier than amending a non-last commit, but even the latter is possible using an interactive rebase.
Anyway, as said, there's not really a problem but I thought you might be happy to know these things for the future. |
Resolves: #19366, #17885
This PR changes the following:
For tuplets, should the using symbols be the default?