Skip to content

[CardMedia] Add separate rules for Image components #17591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 27, 2019
Merged

[CardMedia] Add separate rules for Image components #17591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca82e9e
[CardMedia] Add separate rules for Image components
neon98 Sep 26, 2019
e4370c2
fix build errors
neon98 Sep 26, 2019
ca44e59
incorporate review comments
neon98 Sep 27, 2019
c4aa421
correction in description
neon98 Sep 27, 2019
dd2e755
IE 11 support
oliviertassinari Sep 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/pages/api/card-media.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ Any other props supplied will be provided to the root element (native element).
|:-----|:-------------|:------------|
| <span class="prop-name">root</span> | <span class="prop-name">MuiCardMedia-root</span> | Styles applied to the root element.
| <span class="prop-name">media</span> | <span class="prop-name">MuiCardMedia-media</span> | Styles applied to the root element if `component="video, audio, picture, iframe, or img"`.
| <span class="prop-name">img</span> | <span class="prop-name">MuiCardMedia-img</span> | Styles applied to the root element if `component="picture or img"`.

You can override the style of the component thanks to one of these customization points:

Expand Down
4 changes: 4 additions & 0 deletions packages/material-ui/src/CardMedia/CardMedia.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ export const styles = {
/* Styles applied to the root element if `component="video, audio, picture, iframe, or img"`. */
media: {
width: '100%',
},
/* Styles applied to the root element if `component="picture or img"`. */
img: {
// ⚠️ object-fit is not supported by IE 11.
objectFit: 'cover',
},
Expand Down Expand Up @@ -49,6 +52,7 @@ const CardMedia = React.forwardRef(function CardMedia(props, ref) {
classes.root,
{
[classes.media]: isMediaComponent,
[classes.img]: ['picture', 'img'].indexOf(Component) !== -1,
},
className,
)}
Expand Down