Skip to content

Conversation

@neon98
Copy link
Contributor

@neon98 neon98 commented Sep 26, 2019

fixes #16377

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 26, 2019

Details of bundle changes.

Comparing: 6a80124...dd2e755

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.01% 🔺 +0.02% 🔺 332,340 332,383 90,631 90,646
@material-ui/core/Paper 0.00% 0.00% 68,882 68,882 20,527 20,527
@material-ui/core/Paper.esm 0.00% 0.00% 62,319 62,319 19,264 19,264
@material-ui/core/Popper 0.00% 0.00% 28,397 28,397 10,160 10,160
@material-ui/core/Textarea 0.00% 0.00% 5,082 5,082 2,136 2,136
@material-ui/core/TrapFocus 0.00% 0.00% 3,766 3,766 1,596 1,596
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,348 16,348 5,818 5,818
@material-ui/core/useMediaQuery 0.00% 0.00% 2,488 2,488 1,050 1,050
@material-ui/lab 0.00% 0.00% 143,344 143,344 43,803 43,803
@material-ui/styles 0.00% 0.00% 51,641 51,641 15,353 15,353
@material-ui/system 0.00% 0.00% 15,581 15,581 4,341 4,341
Button 0.00% 0.00% 78,719 78,719 24,031 24,031
Modal 0.00% 0.00% 14,542 14,542 5,113 5,113
Portal 0.00% 0.00% 2,907 2,907 1,318 1,318
Rating 0.00% 0.00% 70,185 70,185 21,915 21,915
Slider 0.00% 0.00% 75,326 75,326 23,248 23,248
colorManipulator 0.00% 0.00% 3,835 3,835 1,519 1,519
docs.landing 0.00% 0.00% 54,267 54,267 14,344 14,344
docs.main 0.00% 0.00% 581,912 581,912 186,264 186,264
packages/material-ui/build/umd/material-ui.production.min.js +0.01% 🔺 +0.04% 🔺 303,122 303,165 87,149 87,184

Generated by 🚫 dangerJS against dd2e755

@joshwooding joshwooding added scope: card Changes related to the card. type: bug It doesn't behave as expected. labels Sep 26, 2019
@neon98
Copy link
Contributor Author

neon98 commented Sep 27, 2019

@joshwooding @merceyz I've made the changes. Feel free to review it 😄

@oliviertassinari
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: card Changes related to the card. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CardMedia] objectFit: cover is not appropriate for iframe

5 participants