Skip to content

Add support for ISO time with and without fractional seconds. #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2019
Merged

Add support for ISO time with and without fractional seconds. #777

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01ff900
Add support for ISO time with and without fractional seconds.
Jul 12, 2019
af645a6
Added comment explaining the need for change.
Jul 12, 2019
6779d71
Merge branch 'master' into master
mikijov Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion minio/parsers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,14 @@ def _iso8601_to_localized_time(date_string):
:param date_string: iso8601 formatted date string.
:return: :class:`datetime.datetime`
"""
parsed_date = datetime.strptime(date_string, '%Y-%m-%dT%H:%M:%S.%fZ')

# Handle timestamps with and without fractional seconds. Some non-AWS
# vendors (e.g. Dell EMC ECS) are not consistent about always providing
# fractional seconds.
try:
parsed_date = datetime.strptime(date_string, '%Y-%m-%dT%H:%M:%S.%fZ')
except ValueError:
parsed_date = datetime.strptime(date_string, '%Y-%m-%dT%H:%M:%SZ')
localized_time = pytz.utc.localize(parsed_date)
return localized_time

Expand Down