Add support for ISO time with and without fractional seconds. #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you state which Amazon S3 implementation is this ? Please mention them in the comment. We may have to remove this code in future, as this should be seen as a workaround. |
|
Added comment into the code. I encountered this issue on Dell EMC ECS. |
|
Build job failed due to some timeout, I have to close/re-open the PR to trigger the build. |
|
Hi @ebozduman, @vadmeste, are there any concerns merging this? We actually need this in production, and we are struggling patching minio-py on the fly... |
|
Thanks for approval. Will someone be able to merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some non Amazon S3 implementations are not consistent about including fractional seconds in the timestamp. The change allows parsing of both
2019-07-10T14:23:39.231Zand2019-07-10T14:23:39Z.