Skip to content

This commit renamed all the occurence of MEILISEARCH_HOST to MEILISEA… #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2022
Merged

This commit renamed all the occurence of MEILISEARCH_HOST to MEILISEA… #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/MeiliSearchIntegrationTests/Utils.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ private let movies: [Movie] = [
public let TESTS_TIME_OUT = 10.0

public func currentHost() -> String {
ProcessInfo.processInfo.environment["MEILISEARCH_HOST"] ?? "http://localhost:7700"
ProcessInfo.processInfo.environment["MEILISEARCH_URL"] ?? "http://localhost:7700"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment in other places, but can you also change the name of the host param? It now should also be url.

example:
client = try MeiliSearch(host: "http://localhost:7700", apiKey: "masterKey") become client = try MeiliSearch(url: "http://localhost:7700", apiKey: "masterKey")

also, in the code-samples.meilisearch.yml and over the README :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better thinking is not the best way to forward with that. We should deprecate the current param first. Then in another PR and another release version, remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, can you "deprecate" the host from MeiliSearch param to merge this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better thinking again, we can do that later. Thanks!

}

public func waitForTask(
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ services:
stdin_open: true
working_dir: /home/package
environment:
- MEILISEARCH_HOST=http://meilisearch:7700
- MEILISEARCH_URL=http://meilisearch:7700
depends_on:
- meilisearch
links:
Expand Down