-
Notifications
You must be signed in to change notification settings - Fork 26
This commit renamed all the occurence of MEILISEARCH_HOST to MEILISEA… #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This commit renamed all the occurence of MEILISEARCH_HOST to MEILISEA… #340
Conversation
Thanks a lot for your contribution @zt4ff :D |
|
||
public func currentHost() -> String { | ||
ProcessInfo.processInfo.environment["MEILISEARCH_HOST"] ?? "http://localhost:7700" | ||
ProcessInfo.processInfo.environment["MEILISEARCH_URL"] ?? "http://localhost:7700" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment in other places, but can you also change the name of the host
param? It now should also be url
.
example:
client = try MeiliSearch(host: "http://localhost:7700", apiKey: "masterKey")
become client = try MeiliSearch(url: "http://localhost:7700", apiKey: "masterKey")
also, in the code-samples.meilisearch.yml
and over the README :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better thinking is not the best way to forward with that. We should deprecate the current param first. Then in another PR and another release version, remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, can you "deprecate" the host
from MeiliSearch
param to merge this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better thinking again, we can do that later. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your PR!
bors merge
This message is sent automatically Thanks again for contributing to Meilisearch ❤️ |
Thanks @brunoocasali |
…RCH_URL
Pull Request
Related issue
Fixes #339
What does this PR do?
PR checklist
Please check if your PR fulfils the following requirements:
Thank you so much for contributing to Meilisearch!