Fix Bug in ServiceMonitor #186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meili-bors bot
added a commit
that referenced
this pull request
Jun 30, 2023
186: Fix Bug in ServiceMonitor r=brunoocasali a=mike-stewart # Pull Request ## What does this PR do? It appears there might be a bug in #153, as there should not be a dash in front of bearerTokenSecret. This is adding it as a second endpoint, when in fact it should be setting the bearerTokenSecret on the http endpoint. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Mike Stewart <[email protected]>
|
Build failed: |
|
@meilisearch sync-manifest |
meili-bors bot
added a commit
that referenced
this pull request
Jun 30, 2023
186: Fix Bug in ServiceMonitor r=brunoocasali a=mike-stewart # Pull Request ## What does this PR do? It appears there might be a bug in #153, as there should not be a dash in front of bearerTokenSecret. This is adding it as a second endpoint, when in fact it should be setting the bearerTokenSecret on the http endpoint. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Mike Stewart <[email protected]> Co-authored-by: Bruno Casali <[email protected]>
|
Thank you @mike-stewart for your contribution! 🤘 |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
It appears there might be a bug in #153, as there should not be a dash in front of bearerTokenSecret. This is adding it as a second endpoint, when in fact it should be setting the bearerTokenSecret on the http endpoint.
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!