ServiceMonitor resource for Prometheus scraping

[nlamirault]

Pull Request

Related issue

• #3523

What does this PR do?

• Creates a ServiceMonitor Kubernetes resources.

Prometheus metrics must be enabled using the --experimental-enable-metrics CLI argument

PR checklist

Please check if your PR fulfills the following requirements:

• Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
• Have you read the contributing guidelines?
• Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

[alallema]

Hi @nlamirault,
Thank you this PR! 🔥
Could you add your new options in the parameters list in the template README? And also could you fill in the description for your PR?
Thank again for contributing to Meilisearch ❤️

[brunoocasali]

@alallema I think this PR will be necessary to the adoption of the new experimental feature meilisearch/meilisearch#3523

So what I suggest you to do is:

• Fix parameters list like you suggested to the contributor
• Add comments and point to the engine issue regarding this experimental feature.
• Add support to Authorization token when a master key protects the instance.

[alallema]

Hi @nlamirault,
Thank you so much for continuing to update your code each time ❤️ . I didn't forget you. I will finish by merging your PR, I just need to check some stuff before and I still don't have time to do it, but I will.
Thank you so much for your patience 😊

[alallema]

Hi @nlamirault,
Sorry to come back to this PR so late. I finally checked it.
Rather than using the CLI command --experimental-enable-metrics, would it be possible to add the MEILI_EXPERIMENTAL_ENABLE_METRICS: "false" parameter to the environment variables and then if {{- if.Values.serviceMonitor.enabled -}} set it as (eq.Values.environment.MEILI_EXPERIMENTAL_ENABLE_METRICS "true")
I'm not an expert, so I'd like your opinion. I can implement it in a subsequent PR if it's annoying.
Thank you 😊

[mike-stewart]

Haven't tested this myself yet, but I was looking at adding a ServiceMonitor to my deployment, and I think you'd need something like this to support authentication, right?

  endpoints:
    - bearerTokenSecret:
        name: meilisearch-master-key
        key: MEILI_MASTER_KEY
...

[alallema]

Hi @mike-stewart,
You're absolutely right thanks! I'll add it to the PR as well as the flag for activated analytics.

[alallema]

bors merge

[meili-bors]

Build succeeded:

• check-chart-manifest-in-sync
• helm-tests
• linter

[meili-bot]

This message is sent automatically

Thank you very much for submitting your PR! Did you know that throughout the month of June we’re holding a rafle?
If you share the link to your merged PR in our #giveaway Discord channel, you’ll automatically join a lottery for a chance at winning some Meiliswag. 🙂
Don’t hesitate to join us: https://discord.com/channels/1006923006964154428/1111273670657200198