Skip to content

Fix error on non array/object/string being highlighted #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 22, 2021
Merged

Fix error on non array/object/string being highlighted #598

merged 2 commits into from
Nov 22, 2021

Conversation

@bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Nov 11, 2021

fixes: #580

@bidoubiwa bidoubiwa requested a review from curquiza November 11, 2021 22:01
alallema
alallema approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

@bidoubiwa bidoubiwa merged commit c28acbd into main Nov 22, 2021
@bidoubiwa bidoubiwa deleted the fix_highlighting_on_undefined branch November 22, 2021 16:41
@bidoubiwa bidoubiwa added the bug Something isn't working label Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curquiza curquiza Awaiting requested review from curquiza

1 more reviewer

@alallema alallema alallema approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Array data type throws exception with recent changes to highlight-adapter.ts (v0.5.7+)

3 participants

@bidoubiwa @alallema