Array data type throws exception with recent changes to highlight-adapter.ts (v0.5.7+)

[chamby]

Description
Array type data being processed for highlighting throws an exception originating from highlight-adapter.ts

"product__tags__ids": [
  67,
  80
],

Expected behavior
No exceptions should be thrown, array data types should be correctly processed.

Current behavior
Array type data being processed for highlighting throws an exception originating from highlight-adapter.ts

Screenshots or Logs

Uncaught (in promise) TypeError: can't access property "replace", _escape__WEBPACK_IMPORTED_MODULE_0__["default"](...) is undefined
    replaceTagsAndEscape escape-highlight.js:21
    recursiveEscape escape-highlight.js:36
    recursiveEscape escape-highlight.js:27
    recursiveEscape escape-highlight.js:26
    recursiveEscape escape-highlight.js:32
    recursiveEscape escape-highlight.js:27
    recursiveEscape escape-highlight.js:26
    hits escape-highlight.js:48
    escapeHits escape-highlight.js:44
    getWidgetRenderState connectInfiniteHits.js:174
    getRenderState connectInfiniteHits.js:142
    render index.js:453
    render index.js:451
    InstantSearch InstantSearch.js:117
    progress defer.js:24
    replaceTagsAndEscape escape-highlight.js:21
    recursiveEscape escape-highlight.js:36
    recursiveEscape escape-highlight.js:27
    recursiveEscape escape-highlight.js:26
    recursiveEscape escape-highlight.js:32
    recursiveEscape escape-highlight.js:27
    recursiveEscape escape-highlight.js:26
    hits escape-highlight.js:48
    escapeHits escape-highlight.js:44
    getWidgetRenderState connectInfiniteHits.js:174
    getRenderState connectInfiniteHits.js:142
    render index.js:453
    render index.js:451
    InstantSearch InstantSearch.js:117
    progress defer.js:24
    promise callback*fn defer.js:16
    init index.js:367
    emit events.js:81
    _dispatchAlgoliaResponse algoliasearch.helper.js:1315
    _dispatchAlgoliaResponse algoliasearch.helper.js:1307
    promise callback*49374/AlgoliaSearchHelper.prototype._search algoliasearch.helper.js:1271
    searchOnlyWithDerivedHelpers algoliasearch.helper.js:154
    search InstantSearch.js:386
    search InstantSearch.js:407
    g events.js:165
    emit events.js:81
    _search algoliasearch.helper.js:1240
    search algoliasearch.helper.js:149
    searchFunction shop-search.vue:632
    search InstantSearch.js:415
    InstantSearch InstantSearch.js:106
    progress defer.js:24
    promise callback*fn defer.js:16
    removeWidgets index.js:271
    handler widget.js:1
    VueJS 12
    searchFunction shop-search.vue:617
    search InstantSearch.js:415
    InstantSearch InstantSearch.js:106
    progress defer.js:24
    promise callback*fn defer.js:16
    start InstantSearch.js:440
    mounted createInstantSearchComponent.js:1
    VueJS 5
    mounted createInstantSearchComponent.js:1
    VueJS 9
escape-highlight.js:21:15

Environment (please complete the following information):

• OS: Ubuntu 20.04
• Browser: Firefox 94.0b9 (64-bit)
• MeiliSearch version: 0.23.1
• instant-meilisearch version: 0.5.7 – 0.5.9
• instantsearch.js version: 4.33.0

[bidoubiwa]

Hey @chamby thanks for raising this error. I will look into it :)

[bidoubiwa]

Could you show me how you configurated your instantsearch components for product__tags__ids ?

[chamby]

Actually, I am not making use of product__tags__ids. All attributes are being fetched and highlighted in the query, not explicitly, just by default.

"attributesToHighlight": [
  "*"
],

In the course of processing the response, this exception is thrown.

[bidoubiwa]

Thanks @chamby I will look into this. Sorry for the bug. If you have any idea on how to resolve it feel free to make a PR. If not, I will fix it asap

[bidoubiwa]

Hey @chamby, I made a fix. It should be released next week if it is approved.
If you want you can already try it out on this branch https://github.com/meilisearch/instant-meilisearch/tree/fix_highlighting_on_undefined