Rewrite client #150
Merged
Rewrite client #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
force-pushed
the
rewrite-client
branch
5 times, most recently
from
4486082 to
390bb39
Compare
This was
linked to
issues
Jun 1, 2021
Closed
alallema
force-pushed
the
rewrite-client
branch
3 times, most recently
from
15b074c to
cd17447
Compare
eskombro
reviewed
Jun 14, 2021
There was a problem hiding this comment.
Amazing work @alallema !
I really think this is improving readability and usability at the same time. The general structure is simplified, without loosing any functionality and making it more friendly. I made a few comments on things that were not clear to me or that I think could be improved, LMKWYT :)
Good job 🎉
Closed
alallema
added
the
breaking-change
Co-authored-by: Samuel Jimenez <[email protected]>
eskombro
suggested changes
Jun 21, 2021
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jun 22, 2021
150: Rewrite client r=alallema a=alallema **Description** Start of SDK go modification: - Rewriting of the Client that implements this method: - Index(uid string) - GetIndex(indexID string) - GetAllIndexes() - CreateIndex(config IndexConfig) - GetOrCreateIndex(config IndexConfig) - GetKeys() - GetAllStats() - CreateDump() - GetDumpStatus(dumpUID string) - Version() - GetVersion() - Health() - IsHealthy() - DeleteIndex(uid string) - Rewriting of the Index that implements this method: - FetchInfo() - FetchPrimaryKey() - ChangePrimaryKey() - Delete() - AddDocuments() - UpdateDocuments() - GetDocument() - GetDocuments() - DeleteOneDocument() - DeletesDocuments() - DeleteAllDocuments() - GetAllUpdateStatus() - GetUpdateStatus() - Search() - GetSettings() - UpdateSettings() - ResetSettings() - GetStats() - WaitForPendingUpdate() - DefaultWaitForPendingUpdate() - Removing of intermediates interfaces - Rewriting of sample and Readme for the new usage - Add tests for every method **To do** - Client - [x] Rewrite Client - [x] Add Test to Client - Index - [x] Rewrite Index - [x] Add Tests to Index - [x] Adding test for `WaitForPendingUpdate()` Issue [related](meilisearch/integration-guides#1) - [x] Rewrite Document - [x] Add Tests to Document - [x] Rewrite Search - [x] Add Tests Search - [x] Rewrite Settings - [x] Add Tests Settings Co-authored-by: alallema <[email protected]>
|
bors r- |
|
Canceled. |
curquiza
approved these changes
Jun 22, 2021
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Start of SDK go modification:
To do
WaitForPendingUpdate()Issue relatedBug
Wrong accepted status code on /health (Health() method) #155