[Feature] Support NDJson and CSV #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Member
brunoocasali
left a comment
brunoocasali
left a comment
There was a problem hiding this comment.
I left some comments, but in fact I think solving the conflicts will help a lot!
| /// * the passed [documents] must be a valid JSON string representing an array of objects. | ||
| /// * If index does not exist, it tries to create a new index and adds documents. | ||
| Future<Task> addDocumentsJson( | ||
| String documents, { |
Member
There was a problem hiding this comment.
The best way to represent the JSON docs is to receive it as string?
Collaborator
Author
There was a problem hiding this comment.
The current addDocuments already receives a parsed json, all these new methods mainly target file contents, so all of them must be raw strings.
or is that not the case ?
Collaborator
Author
|
I have reworked document tests to be more structured and removed some repetitive code, I also organized the comments in macro templates. |
brunoocasali
approved these changes
Mar 14, 2023
Member
brunoocasali
left a comment
brunoocasali
left a comment
There was a problem hiding this comment.
Thanks a lot @ahmednfwela 🎉
bors merge
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102
Depends on #261