Skip to content

[Feature] [add/update]DocumentsInBatches #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 13, 2023
Merged

[Feature] [add/update]DocumentsInBatches #261

merged 8 commits into from
Mar 13, 2023

Conversation

@ahmednfwela
Copy link
Collaborator

@ahmednfwela ahmednfwela commented Mar 11, 2023 •
edited
Loading

Fixes #95

  • Tests added

@ahmednfwela
Copy link
Collaborator Author

ahmednfwela commented Mar 11, 2023

cc @brunoocasali

@ahmednfwela ahmednfwela mentioned this pull request Mar 11, 2023
Merged
1 task
brunoocasali
brunoocasali requested changes Mar 13, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent some suggestions in the test part, but overall is perfect! 🥇

test/documents_test.dart
});

test('Update documents in batches', () async {
const batchSize = 10;
Copy link
Member

@brunoocasali brunoocasali Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent recommendation I like to share whenever is possible: http://blog.plataformatec.com.br/2014/04/improve-your-test-readability-using-the-xunit-structure/

By using this pattern your test structure will look way more readable!

Copy link
Collaborator Author

@ahmednfwela ahmednfwela Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this tip, definitely will use it from now on!

@brunoocasali brunoocasali added the enhancement New feature or request label Mar 13, 2023
brunoocasali
brunoocasali approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 13, 2023

Build succeeded:

@bors bors bot merged commit 9498a4f into meilisearch:main Mar 13, 2023
@ahmednfwela ahmednfwela deleted the feat/addDocumentsInBatches branch March 14, 2023 08:36
bors bot added a commit that referenced this pull request Mar 14, 2023
@bors @ahmednfwela
Merge #262
821cc6e 
262: [Feature] Support NDJson and CSV r=brunoocasali a=ahmednfwela

Fixes #102 
Depends on #261 
- [x] Tests Added

Co-authored-by: Ahmed Fwela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add methods to automatically add/update documents in batches

2 participants

@ahmednfwela @brunoocasali