Bugfix/294 dereferencing callbacks #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….CallbackURL` (OpenAPIKit30)
…Dictionary` (OpenAPIKit30)
mattpolzin
reviewed
Sep 12, 2023
Sources/OpenAPIKit/Utility/OrderedDictionry+LocallyDereferenceable.swift
Outdated
Show resolved
Hide resolved
…ad. (OpenAPIKit30/OpenAPIKit)
mattpolzin
approved these changes
Sep 12, 2023
Owner
mattpolzin
left a comment
mattpolzin
left a comment
There was a problem hiding this comment.
Thanks for fixing this issue! One of the last remaining issues before creating the first v3.0.0 release candidate!
Contributor
Author
|
No problem! Happy to help. 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I add the callbacks when dereferencing a document.
The approach that I took was basically defining DereferencedCallbacks & DereferencedCallbackMap And making OrderedDictionary conforming to LocallyDereferenceable So we can dereferencing Callbacks easily.
This also means that CallbackURL is now conforming to LocallyDereferenceable But basically return itself.