Skip to content

Conversation

@turt2live
Copy link
Member

@turt2live turt2live commented Apr 5, 2021

Should check off enough of #3055 to unfreeze. Incorporates much of #3025, though we may still want to look at #3025 for supplemental documentation.

In collaboration with matrix-org/matrix.org#970


Reviewer: The commits are largely isolated and have a bit of a story progression to them. This isn't a perfect cleanup, but it should be enough to continue spec writing.


The CI is not transitioned fully here, but the now-wasted bytes from the bundle are removed.

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great on the whole. Just a bunch of little fixes and suggestions below.

@turt2live turt2live requested a review from anoadragon453 April 6, 2021 15:45
} else if strings.ToLower(branchName) == "head" ||
branchName == "master" ||
strings.HasPrefix(branchName, "drafts/") {
strings.HasPrefix(branchName, "attic/drafts/") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ctrl+f for the win

@turt2live turt2live merged commit 7a0f6aa into master Apr 6, 2021
@turt2live turt2live deleted the travis/cutover-1 branch April 6, 2021 15:51
@anoadragon453 anoadragon453 mentioned this pull request Apr 6, 2021
5 tasks
richvdh pushed a commit that referenced this pull request Aug 23, 2021
richvdh pushed a commit that referenced this pull request Aug 23, 2021
richvdh pushed a commit that referenced this pull request Aug 23, 2021
Cut over to the new spec authoring platform
richvdh pushed a commit that referenced this pull request Aug 23, 2021
richvdh pushed a commit that referenced this pull request Aug 27, 2021
richvdh pushed a commit that referenced this pull request Aug 27, 2021
richvdh pushed a commit that referenced this pull request Aug 27, 2021
Cut over to the new spec authoring platform
richvdh pushed a commit that referenced this pull request Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants