Skip to content

Conversation

@uhoreg
Copy link
Member

@uhoreg uhoreg commented Sep 5, 2024

changes:

@uhoreg uhoreg force-pushed the update_rust_sdk_20240905 branch from 5024415 to 87c7671 Compare September 5, 2024 21:45
(matrix-rust-sdk#3846, matrix-rust-sdk#3795, matrix-rust-sdk#2629)
@uhoreg uhoreg force-pushed the update_rust_sdk_20240905 branch from 87c7671 to 3e3ace5 Compare September 6, 2024 00:59
@uhoreg
Copy link
Member Author

uhoreg commented Sep 6, 2024

lots of changes, but should be reviewable commit-by-commit.

@uhoreg uhoreg marked this pull request as ready for review September 6, 2024 01:05
@uhoreg uhoreg requested a review from a team as a code owner September 6, 2024 01:05
@uhoreg uhoreg requested a review from BillCarsonFr September 6, 2024 01:05
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo but looks great!


#[wasm_bindgen]
impl CollectStrategy {
/// Tests for equality between two [`CollecStrategy`]s.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CollecStrategy -> CollectStrategy

@andybalaam andybalaam removed the request for review from BillCarsonFr September 6, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants