crypto: Remember whether our own identity has been verified #3846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to make this a tri-state, so let's start by making it an enum.
richvdh
requested review from
BillCarsonFr and
Hywan
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3846 +/- ##
==========================================
+ Coverage 84.10% 84.12% +0.01%
==========================================
Files 262 262
Lines 27594 27617 +23
==========================================
+ Hits 23209 23232 +23
Misses 4385 4385 ☔ View full report in Codecov by Sentry. |
richvdh
force-pushed
the
rav/own_verification_violation
branch
from
301595e to
9b66b62
Compare
andybalaam
approved these changes
Aug 16, 2024
Member
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
Looks good; a couple of minor suggestions.
richvdh
force-pushed
the
rav/own_verification_violation
branch
from
15fc1b2 to
64ac50a
Compare
... and expose new methods to access it.
richvdh
force-pushed
the
rav/own_verification_violation
branch
from
64ac50a to
ae2f0f7
Compare
1 task
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #3795, which extends the same principle to
OwnUserIdentity.Fixes #3845.