Skip to content

Set ObjectFile's assignment operator to also be deleted like its copy constructor #92942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2024
Merged

Set ObjectFile's assignment operator to also be deleted like its copy constructor #92942

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea6d972
Set ObjectFile's assignment operator to also be deleted like its copy…
fsfod May 21, 2024
61b9021
fix declaration of assignment operator
fsfod May 21, 2024
97a4970
run clang format
fsfod May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llvm/include/llvm/Object/ObjectFile.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@ class ObjectFile : public SymbolicFile {
public:
ObjectFile() = delete;
ObjectFile(const ObjectFile &other) = delete;
ObjectFile operator=(const ObjectFile &other) = delete;
Copy link
Member

@MaskRay MaskRay May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ObjectFile &opeartor=

Copy link
Collaborator

@dyung dyung May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be &operator and not &opeartor. I think this typo is causing nearly every buildbot to fail.


uint64_t getCommonSymbolSize(DataRefImpl Symb) const {
Expected<uint32_t> SymbolFlagsOrErr = getSymbolFlags(Symb);
Expand Down