Set ObjectFile's assignment operator to also be deleted like its copy constructor #92942
Conversation
… ctor This will also fix a warning when ObjectFile is dllexport'ed on Windows.
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-llvm-binary-utilities Author: Thomas Fransham (fsfod) ChangesThis will also fix a warning when ObjectFile is dllexport'ed on Windows for my GSOC project for adding support Clang plugins on windows with @vgvassilev and @compnerd. Full diff: https://github.com/llvm/llvm-project/pull/92942.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Object/ObjectFile.h b/llvm/include/llvm/Object/ObjectFile.h
index 8c868c7643edc..645829d944d9f 100644
--- a/llvm/include/llvm/Object/ObjectFile.h
+++ b/llvm/include/llvm/Object/ObjectFile.h
@@ -302,6 +302,7 @@ class ObjectFile : public SymbolicFile {
public:
ObjectFile() = delete;
ObjectFile(const ObjectFile &other) = delete;
+ ObjectFile operator=(const ObjectFile &other) = delete;
uint64_t getCommonSymbolSize(DataRefImpl Symb) const {
Expected<uint32_t> SymbolFlagsOrErr = getSymbolFlags(Symb);
|
| public: | ||
| ObjectFile() = delete; | ||
| ObjectFile(const ObjectFile &other) = delete; | ||
| ObjectFile operator=(const ObjectFile &other) = delete; |
There was a problem hiding this comment.
This should probably be &operator and not &opeartor. I think this typo is causing nearly every buildbot to fail.
You can test this locally with the following command:git-clang-format --diff 3e15c97fa3812993bdc319827a5c6d867b765ae8 61b90212b001cbeea9224a0e7cbfe789ae3cd988 -- llvm/include/llvm/Object/ObjectFile.hView the diff from clang-format here.diff --git a/llvm/include/llvm/Object/ObjectFile.h b/llvm/include/llvm/Object/ObjectFile.h
index 9f60f29262..a50766ccae 100644
--- a/llvm/include/llvm/Object/ObjectFile.h
+++ b/llvm/include/llvm/Object/ObjectFile.h
@@ -302,7 +302,7 @@ protected:
public:
ObjectFile() = delete;
ObjectFile(const ObjectFile &other) = delete;
- ObjectFile &opeartor=(const ObjectFile &other) = delete;
+ ObjectFile &opeartor = (const ObjectFile &other) = delete;
uint64_t getCommonSymbolSize(DataRefImpl Symb) const {
Expected<uint32_t> SymbolFlagsOrErr = getSymbolFlags(Symb);
|
|
Can somebody land that for @fsfod. I do not think he has commit access. |
|
I can merge it once the formatting issue has been addressed. |
|
@fsfod Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested Please check whether problems have been caused by your change specifically, as How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
… constructor (#93072) Reapply #92942, this time double checking it compiles. @vgvassilev, @compnerd.
6 participants
This will also fix a warning when ObjectFile is dllexport'ed on Windows for my GSOC project for adding support Clang plugins on windows with @vgvassilev and @compnerd.